Feat: Automatically obfuscate link title when identical to email #14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! Can you please remove the unrelated changes? |
|
Done. (sorry about that) |
|
Thanks. Just a mental note to keep here. We might wanna check if title is any email instead of the exact same email. Or maybe always obfuscate the title? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
This PR addresses the use case raised in this discussion.
It enhances the link method and x-muddle-link component to automatically obfuscate the link's title when it is the same as the email address. This prevents the email from being exposed in plain text when it needs to serve as both the clickable link and the visible text.
I have added a test case to cover this new behavior and updated the README.md to briefly document it.
Happy to make any adjustments.