CLOUDP-302654: Support apiKey with ip access list on install cmd #156
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
igor-karpukhin
approved these changes
Nov 28, 2025
Collaborator
igor-karpukhin
left a comment
igor-karpukhin
left a comment
There was a problem hiding this comment.
LGTM, but isn't this a breaking change now? I mean, we now require this parameter and it doesn't have a default value
Collaborator
Author
Yes, it is. But this was agreed previously. |
helderjs
force-pushed
the
CLOUDP-302654-install-with-ipacl
branch
from
c01397d to
cc2c751
Compare
Collaborator
Still, we will need to coordinate the release notes and documentation before releasing this change. |
josvazg
reviewed
Dec 1, 2025
Collaborator
josvazg
left a comment
josvazg
left a comment
There was a problem hiding this comment.
LGTM, but I think we must hold merging till after the upcoming AKO release is updated and released for the CLI.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Install command has now a required "ipAccessList" flag that accept a comma separated list of IPs or CIDRs to add as IP Access List entries for the generated APIKey of the installation.
Jira ticket: CLOUDP-302654
Checklist
make fmtand formatted my code