Update validateSpec to return error last
#1684
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m1kola
requested review from
Julien-Ben,
MaciejKaras,
fealebenpae,
lsierant,
lucian-tosa,
mircea-cosbuc and
nammn
as code owners
m1kola
added
the
safe-to-test
nammn
approved these changes
Mar 7, 2025
MaciejKaras
approved these changes
Mar 7, 2025
m1kola
force-pushed
the
fixup_validateSpec
branch
from
ee83035 to
883e113
Compare
m1kola
added
safe-to-test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just fixes
go-staticcheckwarning which complains about error not being last return value: