Fix private_gke_code_snippets + other small fixes (#477)

# Summary

This PR fixes `private_gke_code_snippets` tests that could not properly
set the context:

>scripts/dev/contexts/private_gke_code_snippets: line 13:
/data/mci/33f77d5e70bc4d8e19bb3f674e0743b1/src/github.com/mongodb/mongodb-kubernetes/scripts/dev/contexts/variables/funcs/gke:
No such file or directory

The reason was `om80` context file replaced the `script_dir` variable
that was also set and used in `private_gke_code_snippets`. After that
the `script_dir` pointed to `./scripts/dev/contexts/variables` instead
of `./scripts/dev/contexts/` and the `gke` script could not be found.
The solution was to replace `script_dir` usage in `om80` script with
`PROJECT_DIR`. It was also replaced in other scripts which had long path
based on `script_dir`.

The other thing that was fixed is `switch_context` function. Previously
because we concatenated result from multiple bash commands, we didn't
consume the error code from actual command:

```
      script: |
        echo "Switching context"
        scripts/dev/switch_context.sh "${build_variant}"
        echo "Finished switching context"
```

## Proof of Work

Passing CI + manual patch for
[private_gke_code_snippets](https://spruce.mongodb.com/version/68d50ec1cafe8c000760009e)
.

## Checklist

- [ ] Have you linked a jira ticket and/or is the ticket in the title?
- [ ] Have you checked whether your jira ticket required DOCSP changes?
- [ ] Have you added changelog file?
    - use `skip-changelog` label if not needed
- refer to [Changelog files and Release
Notes](https://github.com/mongodb/mongodb-kubernetes/blob/master/CONTRIBUTING.md#changelog-files-and-release-notes)
section in CONTRIBUTING.md for more details

Author: MaciejKaras

.evergreen-functions.yml

@@ -77,19 +77,15 @@ functions:
         echo "Finished initializing to the root context"
 
   switch_context: &switch_context
-    command: shell.exec
+    command: subprocess.exec
     type: setup
     params:
-      shell: bash
       working_dir: src/github.com/mongodb/mongodb-kubernetes
       <<: *e2e_include_expansions_in_env
       add_to_path:
         - ${workdir}/bin
         - ${workdir}/google-cloud-sdk/bin
-      script: |
-        echo "Switching context"
-        scripts/dev/switch_context.sh "${build_variant}"
-        echo "Finished switching context"
+      command: scripts/dev/switch_context.sh "${build_variant}"
 
   python_venv: &python_venv
     command: subprocess.exec
@@ -249,7 +245,7 @@ functions:
       working_dir: src/github.com/mongodb/mongodb-kubernetes
       add_to_path:
         - ${workdir}/bin
-      command: scripts/dev/setup_chart_testing_cli.sh  
+      command: scripts/dev/setup_chart_testing_cli.sh
 
   lint_repo:
     - command: subprocess.exec
@@ -305,7 +301,6 @@ functions:
   # the task configures the set of tools necessary for any task working with K8 cluster:
   # installs kubectl, jq, kind (if necessary), configures docker authentication
   download_kube_tools:
-    - *switch_context
     - *setup_kubectl
     - *setup_jq
     # we need aws to configure docker authentication

scripts/dev/contexts/e2e_mdb_kind_ubi_cloudqa

@@ -11,7 +11,7 @@ export ops_manager_version="cloud_qa"
 
 # This is required to be able to rebuild the om image and use that image which has been rebuilt
 export OPS_MANAGER_REGISTRY="${BASE_REPO_URL}"
-CUSTOM_OM_VERSION=$(grep -E "^\s*-\s*&ops_manager_70_latest\s+(\S+)\s+#" <"${script_dir}"/../../../.evergreen.yml | awk '{print $3}')
+CUSTOM_OM_VERSION=$(grep -E "^\s*-\s*&ops_manager_70_latest\s+(\S+)\s+#" <"${PROJECT_DIR}"/.evergreen.yml | awk '{print $3}')
 export CUSTOM_OM_VERSION
 
 export CUSTOM_MDB_VERSION=6.0.5

scripts/dev/contexts/e2e_smoke_ibm_power

@@ -10,5 +10,5 @@ source "${script_dir}/variables/e2e_ibm_smoke_base"
 
 # This is required to be able to rebuild the om image and use that image which has been rebuilt
 export OPS_MANAGER_REGISTRY=268558157000.dkr.ecr.us-east-1.amazonaws.com/dev
-CUSTOM_OM_VERSION=$(grep -E "^\s*-\s*&ops_manager_70_latest\s+(\S+)\s+#" <"${script_dir}"/../../../.evergreen.yml | awk '{print $3}')
+CUSTOM_OM_VERSION=$(grep -E "^\s*-\s*&ops_manager_70_latest\s+(\S+)\s+#" <"${PROJECT_DIR}"/.evergreen.yml | awk '{print $3}')
 export CUSTOM_OM_VERSION

scripts/dev/contexts/e2e_smoke_ibm_z

@@ -10,5 +10,5 @@ source "${script_dir}/variables/e2e_ibm_smoke_base"
 
 # This is required to be able to rebuild the om image and use that image which has been rebuilt
 export OPS_MANAGER_REGISTRY=268558157000.dkr.ecr.us-east-1.amazonaws.com/dev
-CUSTOM_OM_VERSION=$(grep -E "^\s*-\s*&ops_manager_70_latest\s+(\S+)\s+#" <"${script_dir}"/../../../.evergreen.yml | awk '{print $3}')
+CUSTOM_OM_VERSION=$(grep -E "^\s*-\s*&ops_manager_70_latest\s+(\S+)\s+#" <"${PROJECT_DIR}"/.evergreen.yml | awk '{print $3}')
 export CUSTOM_OM_VERSION

scripts/dev/contexts/e2e_static_mdb_kind_ubi_cloudqa

@@ -12,7 +12,7 @@ export MDB_DEFAULT_ARCHITECTURE=static
 
 # This is required to be able to rebuild the om image and use that image which has been rebuilt
 export OPS_MANAGER_REGISTRY="${BASE_REPO_URL}"
-CUSTOM_OM_VERSION=$(grep -E "^\s*-\s*&ops_manager_70_latest\s+(\S+)\s+#" <"${script_dir}"/../../../.evergreen.yml | awk '{print $3}')
+CUSTOM_OM_VERSION=$(grep -E "^\s*-\s*&ops_manager_70_latest\s+(\S+)\s+#" <"${PROJECT_DIR}"/.evergreen.yml | awk '{print $3}')
 export CUSTOM_OM_VERSION
 
 export CUSTOM_MDB_PREV_VERSION=6.0.16

scripts/dev/contexts/e2e_static_smoke_arm

@@ -11,7 +11,7 @@ export ops_manager_version="cloud_qa"
 
 # This is required to be able to rebuild the om image and use that image which has been rebuilt
 export OPS_MANAGER_REGISTRY=268558157000.dkr.ecr.us-east-1.amazonaws.com/dev
-CUSTOM_OM_VERSION=$(grep -E "^\s*-\s*&ops_manager_70_latest\s+(\S+)\s+#" <"${script_dir}"/../../../.evergreen.yml | awk '{print $3}')
+CUSTOM_OM_VERSION=$(grep -E "^\s*-\s*&ops_manager_70_latest\s+(\S+)\s+#" <"${PROJECT_DIR}"/.evergreen.yml | awk '{print $3}')
 export CUSTOM_OM_VERSION
 
 export CUSTOM_MDB_VERSION=7.0.22 # we only have ibm static images starting with 7.0.22

scripts/dev/contexts/e2e_static_smoke_ibm_power

@@ -10,7 +10,7 @@ source "${script_dir}/variables/e2e_ibm_smoke_base"
 
 # This is required to be able to rebuild the om image and use that image which has been rebuilt
 export OPS_MANAGER_REGISTRY=268558157000.dkr.ecr.us-east-1.amazonaws.com/dev
-CUSTOM_OM_VERSION=$(grep -E "^\s*-\s*&ops_manager_70_latest\s+(\S+)\s+#" <"${script_dir}"/../../../.evergreen.yml | awk '{print $3}')
+CUSTOM_OM_VERSION=$(grep -E "^\s*-\s*&ops_manager_70_latest\s+(\S+)\s+#" <"${PROJECT_DIR}"/.evergreen.yml | awk '{print $3}')
 export CUSTOM_OM_VERSION
 export MDB_DEFAULT_ARCHITECTURE=static
 # MDB supports ppc64le on RHEL9 only from 8.0.12 onwards

scripts/dev/contexts/e2e_static_smoke_ibm_z

@@ -10,7 +10,7 @@ source "${script_dir}/variables/e2e_ibm_smoke_base"
 
 # This is required to be able to rebuild the om image and use that image which has been rebuilt
 export OPS_MANAGER_REGISTRY=268558157000.dkr.ecr.us-east-1.amazonaws.com/dev
-CUSTOM_OM_VERSION=$(grep -E "^\s*-\s*&ops_manager_70_latest\s+(\S+)\s+#" <"${script_dir}"/../../../.evergreen.yml | awk '{print $3}')
+CUSTOM_OM_VERSION=$(grep -E "^\s*-\s*&ops_manager_70_latest\s+(\S+)\s+#" <"${PROJECT_DIR}"/.evergreen.yml | awk '{print $3}')
 export CUSTOM_OM_VERSION
 export MDB_DEFAULT_ARCHITECTURE=static
 # MDB supports s390x on RHEL9 only from 8.0.12 onwards

scripts/dev/contexts/funcs/gke

@@ -1,3 +1,7 @@
+#!/usr/bin/env bash
+
+set -Eeou pipefail
+
 # Function to normalize identifier to contain only alphanumeric characters.
 # It's also cutting the string in the middle if exceeds max_len.
 # Example:

scripts/dev/contexts/variables/om60

@@ -2,12 +2,9 @@
 
 set -Eeou pipefail
 
-script_name=$(readlink -f "${BASH_SOURCE[0]}")
-script_dir=$(dirname "${script_name}")
-
 CUSTOM_OM_PREV_VERSION=6.0.0
 export CUSTOM_OM_PREV_VERSION
-CUSTOM_OM_VERSION=$(grep -E "^\s*-\s*&ops_manager_60_latest\s+(\S+)\s+#" <"${script_dir}"/../../../../.evergreen.yml | awk '{print $3}')
+CUSTOM_OM_VERSION=$(grep -E "^\s*-\s*&ops_manager_60_latest\s+(\S+)\s+#" <"${PROJECT_DIR}"/.evergreen.yml | awk '{print $3}')
 export CUSTOM_OM_VERSION
 
 export CUSTOM_MDB_VERSION=6.0.21