CLOUDP-332943: Refactor unit test execution

[lsierant]

Summary

This PR simplifies unit tests execution to allow a simple go test ./... to always correctly execute all golang unit tests without running community e2e tests.
Additionally we use gotestsum wrapper by default to better present test output in the command line.

Changes

• There is only one, unified go.mod in the repo now, so running go test ./... correctly identifies all go files. The last one from init-ops-manager was removed in this PR, and another one from kubectl plugin was removed recently in [CLOUDP-332196] Move kubectl-mongodb plugin to cmd dir for atomic releases #271.
• All community e2e tests were marked with community_e2e tag, so we don't need to run tests with a filtered package list anymore.
• gotestsum test runner is used to execute unit tests giving more readable output
• gotestsum has been added as a tool in go.mod by running go get -tool gotest.tools/gotestsum@latest.
  • While using go.mod's tool directive allows for easy tool access (by go tool <tool>) and is not resulting in adding dependencies into the operators binary, it is still cluttering dependency list (in require section). We might consider removing it from go mod and installing it as a separate step.
• All test (python and golang) are reporting results as xml and are all gathered by evg. Test output is gathered in the teardown_task section now.
• Enabled back golang race tests - those were mistakenly disabled during operator merge to MCK (diff unit-tests.sh)

How to run tests now

Essentially as before:

$ make golang-tests

or

$ make test

Difference: we don't run with coverage enabled by default, thus allowing to use test caching for faster repeated runs from cli.

In order to run all unit tests without cache and with coverage run:

$ make golang-tests-race

We is use gotestsum as:

go tool gotestsum --junitfile golang-unit-result.xml --format-icons hivis -- -v ./...

But thanks to the overall go.mod/unitest simplifications you can use whatever suits you:

1. Use gotestsum

$ go tool gotestsum

2. Use plain go test

$ go test ./...

3. Use other test runner/viewers. I recommend to look into gotestsum options as well..

4. Also there is tparse which also has very nice summary table:

go get -tool github.com/mfridman/tparse@latest
go test -v ./... -json | go tool tparse

tparse is not supporting xunit output thus it's not used here as a default.

Proof of Work

Golang unit tests with remove locks to trigger race test error: link
Python unit test with injected error: evg link

Passing tests: evg link

[github-actions]

⚠️ (this preview might not be accurate if the PR is not rebased on current master branch)

MCK 1.6.1 Release Notes

Bug Fixes

• Backed up the agent password in a secret for SCRAM authentication to prevent unnecessary password rotations.
• MongoDB Adding missing ownerrefs to ensure proper resource deletion by kubernetes.
• Single Cluster Deleting resources created by CRD now only happens on multi-cluster deployments. Single Cluster will solely rely on ownerrefs.
• MongoDB, MongoDBOpsManager: Improve validation for featureCompatibilityVersion field in MongoDB and MongoDBOpsManager spec.
  The field now enforces proper semantic versioning. Previously, invalid semver values could be accepted,
  potentially resulting in incorrect configurations.
• Roles configured via Ops Manager UI or API will no longer be removed by the operator

Other Changes

• Future releases will include a new asset, release_info_.json, which provides detailed information about each MongoDB Controllers for Kubernetes release, including a clear list of all container images. This will help customers, especially those running in air-gapped environments, easily identify all required images for a given release.
• Operator configuration: Removed the unused MDB_IMAGE_TYPE environment variable and the corresponding mongodb.imageType Helm value. This variable was deprecated in v1.28.0 of the MongoDB Enterprise Kubernetes Operator when it switched to architecture-based image selection (ubi9 for static, ubi8 for non-static). This is a cleanup change with no functional impact.

[lsierant]

this (and similar additions in other pkgs) is allowing for consistent exec of tests that runs reconcile code across all contexts. The biggest offender was static architecture env which caused different reconcile behavior if tests were executed with different contexts.
Unit tests should never rely on env vars set outside. If those are needed then should be specified in the test itself.

[nammn]

but in theory - the proper way is to fix all those tests which are using global env to t.setEnv() instead, right?
Have you considered doing this instead? Or is that too much of a change?

[viveksinghggits]

Suggested change

	check_backup_daemon_alive
	check_backup_daemon_alive

[viveksinghggits]

should we just remove this, or commenting it ok?

[nammn]

q: on purpose?

[nammn]

but in theory - the proper way is to fix all those tests which are using global env to t.setEnv() instead, right?
Have you considered doing this instead? Or is that too much of a change?