Misuse of get_all_rs in E2E Test #611
Draft
+20
−8
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
While working on this PR, it was discovered that the test multi_cluster_reconcile_races.py incorrectly asserted that get_all_rs (replica sets) runs for all MongoDB resource types, including MongoDBMulti, Sharded, and Standalone. This behavior is a bug.
This PR resolves the issue by ensuring that get_all_rs is only used to test replica set creation. Additionally, get_all_mdbmc, get_all_sharded, and get_all_standalone are now used to verify the creation and behavior of MongoDBMulti, Sharded, and Standalone resources.
However, during testing, it was observed that MongoDBMulti resources are not transitioning to the running stage due to the following error:
Proof of Work
Checklist
skip-changeloglabel if not needed