Clean up component, add dashboard screen, update to sensible menu includes #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
I'm not sure about changing the Example.xml screen from tab to popup, but I'll play with that after merging. It may be difficult to navigate across Edit Example, Items, etc tabs without the tabs, ie with just the header menu or under /qapps the left screen tree. FWIW, even with the left drawer screen tree under /qapps the intent is not to rely on that for navigation. One little detail: please sign the AUTHORS file |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is just because I realized that the example component could use a little bit of fixing.
It's certainly not perfect, but this change makes the app much more usable and adds a link to the site.