Skip to content

Comments

feat(fdc3)- Add functionality for channel selector#1171

Merged
lilla28 merged 2 commits intomorganstanley:mainfrom
lilla28:feat/add-channel-selector-v3
Feb 10, 2026
Merged

feat(fdc3)- Add functionality for channel selector#1171
lilla28 merged 2 commits intomorganstanley:mainfrom
lilla28:feat/add-channel-selector-v3

Conversation

@lilla28
Copy link
Contributor

@lilla28 lilla28 commented Jan 27, 2026

Changes:

  • Added IModuleChannelSelector to be able to detect changes from both UI - when the user would like to join to a user channel, or from the API using the native, TypeScript clients
  • Refactor channel management by replacing ChannelFactory and related interfaces with the new ChannelHandler abstraction across .NET and TypeScript codebases (Renamed internal classes of channel management).
  • All async calls now use .ConfigureAwait(false).
  • Update DesktopAgent, IntentsClient, and related classes to use ChannelHandler, and improve logging, error handling, and resource management.
  • Update tests and public API surface to reflect new abstractions.
  • Add documentation and README updates for channel selector integration.
image

@lilla28 lilla28 requested a review from a team as a code owner January 27, 2026 16:48
@codecov
Copy link

codecov bot commented Jan 27, 2026

Codecov Report

❌ Patch coverage is 81.14035% with 43 lines in your changes missing coverage. Please review.
✅ Project coverage is 65.9%. Comparing base (f12429a) to head (91161c6).
⚠️ Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
...t.Client/Infrastructure/Internal/ChannelHandler.cs 72.9% 9 Missing and 1 partial ⚠️
...pAgent.Client/Infrastructure/DesktopAgentClient.cs 81.0% 6 Missing and 1 partial ⚠️
...oseUI.Fdc3.DesktopAgent/Fdc3DesktopAgentService.cs 88.0% 4 Missing and 2 partials ⚠️
...mposeUI.Fdc3.DesktopAgent/ModuleChannelSelector.cs 81.2% 6 Missing ⚠️
...Infrastructure/Internal/Protocol/PrivateChannel.cs 68.7% 5 Missing ⚠️
.../Infrastructure/Internal/ResolverUICommunicator.cs 33.3% 4 Missing ⚠️
...nt/Infrastructure/Internal/UserChannelSetReader.cs 20.0% 4 Missing ⚠️
...topAgent/Infrastructure/Internal/IntentResolver.cs 50.0% 1 Missing ⚠️

❌ Your patch status has failed because the patch coverage (81.1%) is below the target coverage (100.0%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##            main   #1171     +/-   ##
=======================================
+ Coverage   65.8%   65.9%   +0.1%     
=======================================
  Files        334     335      +1     
  Lines       9755    9821     +66     
  Branches    1283    1291      +8     
=======================================
+ Hits        6420    6477     +57     
- Misses      2955    2971     +16     
+ Partials     380     373      -7     
Files with missing lines Coverage Δ
...nt.Client/Infrastructure/Internal/IntentsClient.cs 92.8% <100.0%> (ø)
...Client/Infrastructure/Internal/Protocol/Channel.cs 96.0% <100.0%> (ø)
...frastructure/Internal/Protocol/IntentResolution.cs 98.0% <100.0%> (ø)
...opAgent.Shared/Contracts/JoinUserChannelRequest.cs 100.0% <ø> (ø)
...pAgent.Shared/Contracts/JoinUserChannelResponse.cs 100.0% <ø> (ø)
...Fdc3.DesktopAgent.Shared/Exceptions/ThrowHelper.cs 62.1% <100.0%> (+1.0%) ⬆️
....Fdc3.DesktopAgent.Shared/Fdc3StartupProperties.cs 100.0% <ø> (ø)
...ey.ComposeUI.Fdc3.DesktopAgent.Shared/Fdc3Topic.cs 93.7% <100.0%> (+0.2%) ⬆️
...DependencyInjection/ServiceCollectionExtensions.cs 100.0% <100.0%> (ø)
...y.ComposeUI.Fdc3.DesktopAgent/Fdc3StartupAction.cs 87.8% <100.0%> (ø)
... and 11 more

... and 4 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@lilla28 lilla28 force-pushed the feat/add-channel-selector-v3 branch 2 times, most recently from aad0a19 to 66bf2e8 Compare January 28, 2026 08:30
psmulovics
psmulovics previously approved these changes Jan 28, 2026
…management by replacing ChannelFactory and related interfaces with the new ChannelHandler abstraction across .NET and TypeScript codebases (Renamed internal classes of channel management). All async calls now use .ConfigureAwait(false). Update DesktopAgent, IntentsClient, and related classes to use ChannelHandler, and improve logging, error handling, and resource management. Update tests and public API surface to reflect new abstractions. Add documentation and README updates for channel selector integration.
@lilla28 lilla28 merged commit c8bf6bb into morganstanley:main Feb 10, 2026
4 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants