feat(fdc3)- Add functionality for channel selector#1171
Merged
lilla28 merged 2 commits intomorganstanley:mainfrom Feb 10, 2026
Merged
feat(fdc3)- Add functionality for channel selector#1171lilla28 merged 2 commits intomorganstanley:mainfrom
lilla28 merged 2 commits intomorganstanley:mainfrom
Conversation
Codecov Report❌ Patch coverage is ❌ Your patch status has failed because the patch coverage (81.1%) is below the target coverage (100.0%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #1171 +/- ##
=======================================
+ Coverage 65.8% 65.9% +0.1%
=======================================
Files 334 335 +1
Lines 9755 9821 +66
Branches 1283 1291 +8
=======================================
+ Hits 6420 6477 +57
- Misses 2955 2971 +16
+ Partials 380 373 -7
🚀 New features to boost your workflow:
|
aad0a19 to
66bf2e8
Compare
psmulovics
previously approved these changes
Jan 28, 2026
…management by replacing ChannelFactory and related interfaces with the new ChannelHandler abstraction across .NET and TypeScript codebases (Renamed internal classes of channel management). All async calls now use .ConfigureAwait(false). Update DesktopAgent, IntentsClient, and related classes to use ChannelHandler, and improve logging, error handling, and resource management. Update tests and public API surface to reflect new abstractions. Add documentation and README updates for channel selector integration.
66bf2e8 to
3f4ea2e
Compare
ZKRobi
approved these changes
Feb 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes:
IModuleChannelSelectorto be able to detect changes from both UI - when the user would like to join to a user channel, or from the API using the native, TypeScript clients