Skip to content

Add PVDO table and PVTTableSet return type to PVTExperiments#28

Merged
moyner merged 2 commits intomainfrom
copilot/add-pvdo-output-to-pvtables
Mar 17, 2026
Merged

Add PVDO table and PVTTableSet return type to PVTExperiments#28
moyner merged 2 commits intomainfrom
copilot/add-pvdo-output-to-pvtables

Conversation

Copy link
Contributor

Copilot AI commented Mar 17, 2026

generate_pvt_tables always generated PVDG but had no equivalent dead oil (PVDO) table, and returned an anonymous NamedTuple making downstream type dispatch impossible.

Changes

  • New PVDOTable struct — mirrors PVDGTable with p, Bo, mu_o fields
  • New PVTTableSet struct — typed container replacing the NamedTuple return; exported so downstream packages can dispatch on it
  • pvdo_table function — always generated like PVDG; uses overall composition for oil systems, liquid composition near dew point for gas systems
  • generate_pvt_tables updates — adds n_pvdo kwarg (default: 20), generates PVDO, returns PVTTableSet
  • Base.show methods for PVDOTable and PVTTableSet

Usage

tables = generate_pvt_tables(eos, z, T_res)

tables isa PVTTableSet        # true — dispatchable type
tables.pvdo isa PVDOTable     # true — always generated
tables.pvdg isa PVDGTable     # true — always generated
tables.pvto                   # PVTOTable or nothing (oil systems)
tables.pvtg                   # PVTGTable or nothing (gas systems)

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • https://api.github.com/repos/FluxML/MacroTools.jl/tarball/1e0228a030642014fe5cfe68c2c0a818f9e3f522
    • Triggering command: /usr/bin/julia julia --project=. -e import Pkg; Pkg.instantiate() (http block)
  • https://api.github.com/repos/JuliaArrays/StaticArrays.jl/tarball/246a8bb2e6667f832eea063c3a56aef96429a3db
    • Triggering command: /usr/bin/julia julia --project=. -e import Pkg; Pkg.instantiate() (http block)
  • https://api.github.com/repos/JuliaArrays/StaticArraysCore.jl/tarball/6ab403037779dae8c514bad259f32a447262455a
    • Triggering command: /usr/bin/julia julia --project=. -e import Pkg; Pkg.instantiate() (http block)
  • https://api.github.com/repos/JuliaBinaryWrappers/OpenSpecFun_jll.jl/tarball/1346c9208249809840c91b26703912dff463d335
    • Triggering command: /usr/bin/julia julia --project=. -e import Pkg; Pkg.instantiate() (http block)
  • https://api.github.com/repos/JuliaDiff/DiffResults.jl/tarball/782dd5f4561f5d267313f23853baaaa4c52ea621
    • Triggering command: /usr/bin/julia julia --project=. -e import Pkg; Pkg.instantiate() (http block)
  • https://api.github.com/repos/JuliaDiff/DiffRules.jl/tarball/23163d55f885173722d1e4cf0f6110cdbaf7e272
    • Triggering command: /usr/bin/julia julia --project=. -e import Pkg; Pkg.instantiate() (http block)
  • https://api.github.com/repos/JuliaDiff/ForwardDiff.jl/tarball/eef4c86803f47dcb61e9b8790ecaa96956fdd8ae
    • Triggering command: /usr/bin/julia julia --project=. -e import Pkg; Pkg.instantiate() (http block)
  • https://api.github.com/repos/JuliaDocs/DocStringExtensions.jl/tarball/7442a5dfe1ebb773c29cc2962a8980f47221d76c
    • Triggering command: /usr/bin/julia julia --project=. -e import Pkg; Pkg.instantiate() (http block)
  • https://api.github.com/repos/JuliaFunctional/CompositionsBase.jl/tarball/802bb88cd69dfd1509f6670416bd4434015693ad
    • Triggering command: /usr/bin/julia julia --project=. -e import Pkg; Pkg.instantiate() (http block)
  • https://api.github.com/repos/JuliaLang/PrecompileTools.jl/tarball/07a921781cab75691315adc645096ed5e370cb77
    • Triggering command: /usr/bin/julia julia --project=. -e import Pkg; Pkg.instantiate() (http block)
  • https://api.github.com/repos/JuliaMath/InverseFunctions.jl/tarball/a779299d77cd080bf77b97535acecd73e1c5e5cb
    • Triggering command: /usr/bin/julia julia --project=. -e import Pkg; Pkg.instantiate() (http block)
  • https://api.github.com/repos/JuliaMath/IrrationalConstants.jl/tarball/b2d91fe939cae05960e760110b328288867b5758
    • Triggering command: /usr/bin/julia julia --project=. -e import Pkg; Pkg.instantiate() (http block)
  • https://api.github.com/repos/JuliaMath/NaNMath.jl/tarball/9b8215b1ee9e78a293f99797cd31375471b2bcae
    • Triggering command: /usr/bin/julia julia --project=. -e import Pkg; Pkg.instantiate() (http block)
  • https://api.github.com/repos/JuliaMath/Roots.jl/tarball/10a488dbecb88a9679c8f357d383d7d83dcc748d
    • Triggering command: /usr/bin/julia julia --project=. -e import Pkg; Pkg.instantiate() (http block)
  • https://api.github.com/repos/JuliaMath/SpecialFunctions.jl/tarball/5acc6a41b3082920f79ca3c759acbcecf18a8d78
    • Triggering command: /usr/bin/julia julia --project=. -e import Pkg; Pkg.instantiate() (http block)
  • https://api.github.com/repos/JuliaObjects/Accessors.jl/tarball/856ecd7cebb68e5fc87abecd2326ad59f0f911f3
    • Triggering command: /usr/bin/julia julia --project=. -e import Pkg; Pkg.instantiate() (http block)
  • https://api.github.com/repos/JuliaObjects/ConstructionBase.jl/tarball/b4b092499347b18a015186eae3042f72267106cb
    • Triggering command: /usr/bin/julia julia --project=. -e import Pkg; Pkg.instantiate() (http block)
  • https://api.github.com/repos/JuliaPackaging/JLLWrappers.jl/tarball/0533e564aae234aff59ab625543145446d8b6ec2
    • Triggering command: /usr/bin/julia julia --project=. -e import Pkg; Pkg.instantiate() (http block)
  • https://api.github.com/repos/JuliaPackaging/Preferences.jl/tarball/8b770b60760d4451834fe79dd483e318eee709c4
    • Triggering command: /usr/bin/julia julia --project=. -e import Pkg; Pkg.instantiate() (http block)
  • https://api.github.com/repos/JuliaStats/LogExpFunctions.jl/tarball/13ca9e2586b89836fd20cccf56e57e2b9ae7f38f
    • Triggering command: /usr/bin/julia julia --project=. -e import Pkg; Pkg.instantiate() (http block)
  • https://api.github.com/repos/SciML/CommonSolve.jl/tarball/78ea4ddbcf9c241827e7035c3a03e2e456711470
    • Triggering command: /usr/bin/julia julia --project=. -e import Pkg; Pkg.instantiate() (http block)
  • https://api.github.com/repos/rdeits/CommonSubexpressions.jl/tarball/cda2cfaebb4be89c9084adaca7dd7333369715c5
    • Triggering command: /usr/bin/julia julia --project=. -e import Pkg; Pkg.instantiate() (http block)
  • pkg.julialang.org
    • Triggering command: /usr/bin/julia julia --project=. -e import Pkg; Pkg.instantiate() (dns block)

If you need me to access, download, or install something from one of these locations, you can either:


✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Co-authored-by: moyner <454871+moyner@users.noreply.github.com>
Copilot AI changed the title [WIP] Add PVDO output to PVT tables generation Add PVDO table and PVTTableSet return type to PVTExperiments Mar 17, 2026
Copilot AI requested a review from moyner March 17, 2026 09:09
@moyner moyner marked this pull request as ready for review March 17, 2026 09:12
@moyner moyner merged commit 7a23d8a into main Mar 17, 2026
5 checks passed
@moyner moyner deleted the copilot/add-pvdo-output-to-pvtables branch March 17, 2026 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants