Bug 1517996 - Add a link back to the user's profile from the Activity Report page#1523
Open
KWierso wants to merge 1 commit intomozilla-bteam:masterfrom
Open
Bug 1517996 - Add a link back to the user's profile from the Activity Report page#1523KWierso wants to merge 1 commit intomozilla-bteam:masterfrom
KWierso wants to merge 1 commit intomozilla-bteam:masterfrom
Conversation
dklawren
requested changes
Mar 6, 2020
| $vars->{'incomplete_data'} = $incomplete_data; | ||
| $vars->{'operations'} = \@operations; | ||
|
|
||
| $vars->{user} = Bugzilla::User->new({ name => $input->{who}, cached => 1 }); |
Collaborator
There was a problem hiding this comment.
This is inside the for loop that stores each activity item. So depending on how many activity rows there are, it will be set each time. Also user_activity.html allows for displaying more than one person grouped together. Normally from user_profile.html, the link to user_activity.html would only be a single person so wouldn't be an issue with that case. But we need to be able to handle both cases.
So out side of the for loop you need to create $var->{users}:
$var->{users}
= [ map { Bugzilla::User->new({ name => $_, cache => 1}) } @who ];|
|
||
| <p> | ||
| <a href="[% basepath FILTER none %]user_profile?user_id=[% user.id FILTER uri %]"> User Profile</a> | ||
| </p> |
Collaborator
There was a problem hiding this comment.
We need to deal with the possibility that multiple users were searched on instead of always coming from user_profile.html so we may need a loop here:
<p>
User Profiles:
[% FOREACH u = users %]
<a href="[% basepath FILTER none %]user_profile?user_id=[% u.id FILTER uri %]">[% user.name FILTER html %]</a>[% ", " IF NOT loop.last() %]
[% END %]
</p>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…