Skip to content

Remove FXIOS-12223 [Toolbar] Remove baseline version #29592

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Sep 29, 2025
Merged

Remove FXIOS-12223 [Toolbar] Remove baseline version #29592

merged 7 commits into from
Sep 29, 2025

Conversation

thatswinnie
Copy link
Collaborator

📜 Tickets

Jira ticket
Github issue

💡 Description

Removes the baseline toolbar version from code. We already defaulted to display version1 when the user had baseline selected so this should have no impact on the users UI.

Do not merge before the branch for 143.2 is created!

📝 Checklist

  • I filled in the ticket numbers and a description of my work
  • I updated the PR name to follow our PR naming guidelines
  • I ensured unit tests pass and wrote tests for new code
  • If working on UI, I checked and implemented accessibility (Dynamic Text and VoiceOver)
  • If adding telemetry, I read the data stewardship requirements and will request a data review
  • If adding or modifying strings, I read the guidelines and will request a string review from l10n
  • If needed, I updated documentation and added comments to complex code
  • If needed, I added a backport comment (example @Mergifyio backport release/v150.0)

@thatswinnie
Remove baseline version
0b1d27d
@thatswinnie
Merge branch 'main' into wt/FXIOS-12223-remove-baseline-version
eee5719
@thatswinnie
Merge remote-tracking branch 'origin/main' into wt/FXIOS-12223-remove…
4039bf7 
…-baseline-version
@thatswinnie
Merge branch 'main' into wt/FXIOS-12223-remove-baseline-version
82a575d 
# Conflicts:
#	BrowserKit/Sources/ToolbarKit/AddressToolbar/LocationView/LocationView.swift
#	BrowserKit/Sources/ToolbarKit/AddressToolbar/LocationView/LocationViewAppearanceConfiguration.swift
@thatswinnie
Optimize code
3dda8a6
@thatswinnie thatswinnie requested a review from a team as a code owner September 25, 2025 06:09
@mobiletest-ci-bot
Copy link

mobiletest-ci-bot commented Sep 25, 2025 •
edited
Loading

Messages
📖 Project coverage: 37.73%

🧹 Tidy commit

Just 5 file(s) touched. Thanks for keeping it clean and review-friendly!

Client.app: Coverage: 37.28

File Coverage
TabWebViewPreviewAppearanceConfiguration.swift 0.0% ⚠️
ToolbarLayoutStyle.swift 100.0% ✅
OnboardingKitCardInfoModel.swift 94.12% ✅
OnboardingMultipleChoiceCardViewController.swift 2.13% ⚠️

Generated by 🚫 Danger Swift against 660debb

FilippoZazzeroni
FilippoZazzeroni approved these changes Sep 25, 2025
View reviewed changes
Copy link
Collaborator

@FilippoZazzeroni FilippoZazzeroni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So happy this code is removed 🥳

@thatswinnie thatswinnie merged commit 3f56b5c into main Sep 29, 2025
8 checks passed
@thatswinnie thatswinnie deleted the wt/FXIOS-12223-remove-baseline-version branch September 29, 2025 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FilippoZazzeroni FilippoZazzeroni FilippoZazzeroni approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@thatswinnie @mobiletest-ci-bot @FilippoZazzeroni