Skip to content

Conversation

isabelrios
Copy link

📜 Tickets

Jira ticket
Github issue

💡 Description

📝 Checklist

You have to check all boxes before merging

  • Filled in the above information (tickets numbers and description of your work)
  • Updated the PR name to follow our PR naming guidelines
  • Wrote unit tests and/or ensured the tests suite is passing
  • When working on UI, I checked and implemented accessibility (minimum Dynamic Text and VoiceOver)
  • If needed, I updated documentation / comments for complex code and public methods
  • If needed, added a backport comment (example @Mergifyio backport release/v120)

@Eijebong Eijebong force-pushed the main branch 6 times, most recently from 9cf3242 to d729fbd Compare May 26, 2025 12:04
@Eijebong Eijebong force-pushed the main branch 3 times, most recently from a87be38 to 068d303 Compare June 3, 2025 10:13
@Eijebong Eijebong force-pushed the main branch 7 times, most recently from 0ad3a8a to 2240f9a Compare July 9, 2025 15:44
@Eijebong Eijebong force-pushed the main branch 2 times, most recently from 363c24e to c2b885b Compare July 24, 2025 15:50
@hneiva hneiva force-pushed the main branch 3 times, most recently from 467ae6a to 7f84160 Compare July 24, 2025 20:39
@Eijebong Eijebong force-pushed the main branch 7 times, most recently from 82ab343 to 9134134 Compare August 5, 2025 16:19
hneiva pushed a commit that referenced this pull request Sep 11, 2025
…from last week (#3) (mozilla-mobile#29102)

* Refactor FXIOS-12796 [Swift 6 Migration] UnifiedAdsProvider warning (mozilla-mobile#28933)

remove: making topsitesmanager sendable to not introduce more warnings

fix: bad cyndi for removing something needed

* Refactor FXIOS-12796 [Swift 6 Migration] Shared - Address warnings in `UIBarButtonItemExtensions`  (mozilla-mobile#28925)

* Remove `UIBarButtonItemExtensions` code in Shared to address shared mutable state concurrency errors.

* Rewrite usage of UIBarButtonItemExtensions code in ExperimentsViewController to use a nonisolated selector method instead.

* Rewrite usage of UIBarButtonItemExtensions code in UIViewController+Extension to use a nonisolated selector method instead.

* Refactor FXIOS-13299 [Swift 6 Migration] Use ensureMainThread instead (mozilla-mobile#28948)

Use ensureMainThread instead

* Refactor FXIOS-12796 [Swift 6 Migration] Enable strict concurrency checking in the Shared BrowserKit package (mozilla-mobile#28714)

Enable strict concurrency checking in the Shared BrowserKit package.

* Refactor FXIOS-12796 [Swift 6 Migration] Resolve Errors in PinnedSites Files (mozilla-mobile#28957)

---------

Co-authored-by: Cyndi Chin <[email protected]>
Co-authored-by: lmarceau <[email protected]>
Co-authored-by: Sophie <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants