[DENG-9732] Filter out remotecontent events from event etl #8140
+74
−36
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
sean-rose
reviewed
Sep 23, 2025
| AND 87 | ||
| ) | ||
| AND | ||
| ) IS FALSE |
There was a problem hiding this comment.
issue: Using IS FALSE means that the event will be excluded if one or more of the fields being checked is null (including event extras being checked not being present) while the rest of the non-null field conditions match.
If that isn't the intended behavior then I'd recommend using IS NOT TRUE instead (same goes for the other usages of IS FALSE).
Comment on lines
12
to
20
| TIMESTAMP_ADD( | ||
| TIMESTAMP_TRUNC(submission_timestamp, HOUR), | ||
| -- Aggregates event counts over 60-minute intervals | ||
| INTERVAL(DIV(EXTRACT(MINUTE FROM submission_timestamp), 60) * 60) MINUTE | ||
| ) AS window_start, | ||
| TIMESTAMP_ADD( | ||
| TIMESTAMP_TRUNC(submission_timestamp, HOUR), | ||
| INTERVAL((DIV(EXTRACT(MINUTE FROM submission_timestamp), 60) + 1) * 60) MINUTE | ||
| ) AS window_end, |
There was a problem hiding this comment.
suggestion (non-blocking): I see this was existing code just being moved into this CTE, but this logic doesn't make sense to me since the extracted minute will always be less than 60, in which case DIV(EXTRACT(MINUTE FROM submission_timestamp), 60) would always evaluate to zero, and this could be simplified:
Suggested change
| TIMESTAMP_ADD( | |
| TIMESTAMP_TRUNC(submission_timestamp, HOUR), | |
| -- Aggregates event counts over 60-minute intervals | |
| INTERVAL(DIV(EXTRACT(MINUTE FROM submission_timestamp), 60) * 60) MINUTE | |
| ) AS window_start, | |
| TIMESTAMP_ADD( | |
| TIMESTAMP_TRUNC(submission_timestamp, HOUR), | |
| INTERVAL((DIV(EXTRACT(MINUTE FROM submission_timestamp), 60) + 1) * 60) MINUTE | |
| ) AS window_end, | |
| TIMESTAMP_TRUNC(submission_timestamp, HOUR) AS window_start, | |
| TIMESTAMP_ADD( | |
| TIMESTAMP_TRUNC(submission_timestamp, HOUR), | |
| INTERVAL 1 HOUR | |
| ) AS window_end, |
Or am I missing something?
There was a problem hiding this comment.
Yes it's equivalent. I'll change it
| event_name, | ||
| event_extra_key, | ||
| country, | ||
| normalized_app_name, |
There was a problem hiding this comment.
suggestion (blocking): I presume trying to group by normalized_app_name would fail given you removed that column from this CTE above.
Suggested change
| normalized_app_name, |
There was a problem hiding this comment.
The query works because normalized_app_name is in the source table but yes this should be removed
Comment on lines
63
to
64
| experiment, | ||
| experiment_branch |
There was a problem hiding this comment.
nitpick: Indentation.
Suggested change
| experiment, | |
| experiment_branch | |
| experiment, | |
| experiment_branch |
Comment on lines
69
to
70
| "{{ dataset['canonical_app_name'] }}" AS normalized_app_name, | ||
| * REPLACE (SUM(total_events) AS total_events), |
There was a problem hiding this comment.
issue: This is changing the order of the columns being returned, which seems like something we should avoid if we can.
Suggested change
| "{{ dataset['canonical_app_name'] }}" AS normalized_app_name, | |
| * REPLACE (SUM(total_events) AS total_events), | |
| submission_date, | |
| window_start, | |
| window_end, | |
| event_category, | |
| event_name, | |
| event_extra_key, | |
| country, | |
| "{{ dataset['canonical_app_name'] }}" AS normalized_app_name, | |
| channel, | |
| version, | |
| experiment, | |
| experiment_branch, | |
| SUM(total_events) AS total_events, |
| AND ( | ||
| event.category = "uptake.remotecontent.result" | ||
| AND event.name IN ("uptake_remotesettings", "uptake_normandy") | ||
| AND mozfun.norm.extract_version(client_info.app_display_version, 'major') >= 143 |
There was a problem hiding this comment.
suggestion (non-blocking): Here we have an app_version_major column readily available.
Suggested change
| AND mozfun.norm.extract_version(client_info.app_display_version, 'major') >= 143 | |
| AND app_version_major >= 143 |
BenWu
force-pushed
the
benwu/filter-remotecontent-143
branch
from
8b81bbf to
a8a3b0a
Compare
Integration report for "Clean up + only filter release channel"
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This filters the high volume
uptake.remotecontent.resultevents from legacy and glean event tables. This might fix theevent_monitoring_aggregates_v1failures but I'm still waiting for the queries to finish.I also rearranged the
event_monitoring_aggregates_v1query a bit to aggregate events per ping before aggregating per app since I found that it uses slightly less slot time and shuffleRelated Tickets & Documents
Reviewer, please follow this checklist