aaudio: Load libaaudio.so once globally, rather than for each cubeb context.
#830
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use a global singleton to load
libaaudio.sorather than loading (and unloading) it dynamically for each cubeb context.On Firefox CI or when running GTests locally, a crash with the following stack may occur:
The crash can happen after the last currently active cubeb context is closed, dependent on recent AAudio activity and scheduling of the various processes involved.
This is a result of unloading
libaaudio.sowhen destroying a cubeb context.libaaudio.sohas a global AAudioBinderClient singleton that handles Binder work. If this singleton is destroyed by unloading the DSO while BInder work is in-flight, a crash inside the Binder thread pool will occur.Since there's no external way to know when it's safe to unload
libaaudio.soand it's unnecessary to load and unload a copy for each cubeb context, we can avoid this crash by loadinglibaaudio.soa single time when first used and only unload it when the singleton is destroyed (as the process exits).If the crash is still observed when unloading at process exist, we can disable unloading and "leak" the library until process exit. I'll make this change later, if it seems necessary.