Skip to content

fix(admin-panel): fix incorrect bounce types #19516

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 3, 2025
Merged

fix(admin-panel): fix incorrect bounce types #19516

merged 1 commit into from
Oct 3, 2025
+14 −15

Conversation

MagentaManifold
Copy link
Contributor

@MagentaManifold MagentaManifold commented Sep 29, 2025 •
edited
Loading

Because

  • the bounce types displayed are wrong and does not match our data in the database.

This pull request

  • makes sure the displayed bounce types and the auth server db match.

Issue that this pull request solves

Closes: FXA-11612

Checklist

Put an x in the boxes that apply

  • My commit is GPG signed.
  • If applicable, I have modified or added tests which pass locally.
  • I have added necessary documentation (if appropriate).
  • I have verified that my changes render correctly in RTL (if appropriate).

Screenshots (Optional)

Please attach the screenshots of the changes made in case of change in user interface.

Other information (Optional)

Any other information that is important to this pull request.

@MagentaManifold
fix(admin-panel): fix incorrect bounce types
b95673a 
Because:

* the bounce types displayed are wrong and does not match our data in the database.

This commit:

* makes sure the displayed bounce types and the auth server db match.

Closes #FXA-11612
@MagentaManifold MagentaManifold marked this pull request as ready for review September 29, 2025 15:42
@MagentaManifold MagentaManifold requested a review from a team as a code owner September 29, 2025 15:42
@nshirley
Copy link
Contributor

nshirley commented Oct 3, 2025

Code changes look good, just pulling your branch to test locally then I'll 👍 !

nshirley
nshirley approved these changes Oct 3, 2025
View reviewed changes
Copy link
Contributor

@nshirley nshirley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 I wasn't able to fully test locally but looks good to me.

@MagentaManifold
Copy link
Contributor Author

I wasn't able to simulate email bounces locally, but I did test by manually inserting email bounces into the DB.

@MagentaManifold MagentaManifold merged commit 4f2d47a into main Oct 3, 2025
19 checks passed
@MagentaManifold MagentaManifold deleted the FXA-11612 branch October 3, 2025 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nshirley nshirley nshirley approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MagentaManifold @nshirley