Skip to content

Conversation

vbudhram
Copy link
Contributor

@vbudhram vbudhram commented Sep 29, 2025

Because

  • These checks are now being handled in the sessionVerifiedToken auth scheme

This pull request

  • Removes reduduant checks

Issue that this pull request solves

Closes: https://mozilla-hub.atlassian.net/browse/FXA-12437

Checklist

  • My commit is GPG signed.
  • If applicable, I have modified or added tests which pass locally.
  • I have added necessary documentation (if appropriate).
  • I have verified that my changes render correctly in RTL (if appropriate).

@vbudhram vbudhram requested a review from a team as a code owner September 29, 2025 17:19
@vbudhram vbudhram requested a review from dschom October 2, 2025 16:19
const { email, uid } = request.auth.credentials;

const account = await db.account(uid);
if (!account.emailVerified) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this needed now.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's also a check on line 556 in /totp/destroy that's not needed.

Copy link
Contributor

@dschom dschom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check out my comment about two totp checks that probably aren't needed anymroe.

Other than that it looks good! I think we will need do this same sort of thing again when we address FXA-12420.

Thanks for the changes! :shipit:

@vbudhram vbudhram merged commit 810c5cc into main Oct 8, 2025
19 checks passed
@vbudhram vbudhram deleted the fxa-12437 branch October 8, 2025 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants