Add telemetry for tagged pdfs (bug 1997134) #20405
Conversation
|
/botio integrationtest |
From: Bot.io (Linux m4)ReceivedCommand cmd_integrationtest from @calixteman received. Current queue size: 0 Live output at: http://54.241.84.105:8877/63998603fff3c95/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_integrationtest from @calixteman received. Current queue size: 0 Live output at: http://54.193.163.58:8877/6d6038eccc3cec9/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/63998603fff3c95/output.txt Total script time: 19.62 mins
|
From: Bot.io (Windows)SuccessFull output at http://54.193.163.58:8877/6d6038eccc3cec9/output.txt Total script time: 44.39 mins
|
timvandermeij
left a comment
timvandermeij
left a comment
There was a problem hiding this comment.
r=me, with the comments addressed. Thanks!
| return Promise.all([ | ||
| pdfManager.ensureDoc("documentInfo"), | ||
| pdfManager.ensureCatalog("metadata"), | ||
| Promise.resolve(pdfManager.pdfDocument.catalog.hasStructTree()), |
There was a problem hiding this comment.
Shouldn't we be using pdfManager.ensureCatalog("hasStructTree") here, similar to how we fetch the other metadata just above, to make sure that the catalog is loaded at this point?
| return markInfo; | ||
| } | ||
|
|
||
| hasStructTree() { |
There was a problem hiding this comment.
If ensureCatalog is used in the other comment, this should probably become get hasStructTree (which we may also want to shadow afterwards).
3 participants
No description provided.