-
Notifications
You must be signed in to change notification settings - Fork 10.5k
Add the possibility to create a pdf from different ones (bug 1997379) #20409
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
6df136f to
9114af7
Compare
ff5a566 to
c4f05f4
Compare
timvandermeij
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
r=me, with the final comments addressed, WIP removed from the commit message and passing tests. Nice work!
c4f05f4 to
363356a
Compare
|
/botio test |
From: Bot.io (Windows)ReceivedCommand cmd_test from @calixteman received. Current queue size: 0 Live output at: http://54.193.163.58:8877/5619354ac07dafc/output.txt |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @calixteman received. Current queue size: 0 Live output at: http://54.241.84.105:8877/a766a7c095d6d61/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/a766a7c095d6d61/output.txt Total script time: 60.00 mins |
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/5619354ac07dafc/output.txt Total script time: 79.13 mins
Image differences available at: http://54.193.163.58:8877/5619354ac07dafc/reftest-analyzer.html#web=eq.log |
For now it's just possible to create a single pdf in selecting some pages in different pdf sources. The merge is for now pretty basic (it's why it's still a WIP) none of these data are merged for now: - the struct trees - the page labels - the outlines - named destinations For there are 2 new ref tests where some new pdfs are created: one with some extracted pages and an other one (encrypted) which is just rewritten. The ref images are generated from the original pdfs in selecting the page we want and the new images are taken from the generated pdfs.
363356a to
bc87f4e
Compare
|
The regressions are due to: |
|
/botio makeref |
From: Bot.io (Windows)ReceivedCommand cmd_makeref from @calixteman received. Current queue size: 0 Live output at: http://54.193.163.58:8877/c3d100efb509041/output.txt |
From: Bot.io (Linux m4)ReceivedCommand cmd_makeref from @calixteman received. Current queue size: 0 Live output at: http://54.241.84.105:8877/fc109caa87599fc/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/fc109caa87599fc/output.txt Total script time: 17.83 mins
|
From: Bot.io (Windows)SuccessFull output at http://54.193.163.58:8877/c3d100efb509041/output.txt Total script time: 32.36 mins
|
For now it's just possible to create a single pdf in selecting some pages in different pdf sources. The merge is for now pretty basic (it's why it's still a WIP) none of these data are merged for now:
The ref images are generated from the original pdfs in selecting the page we want and the new images are taken from the generated pdfs.