Skip to content

Conversation

@calixteman
Copy link
Contributor

No description provided.

@calixteman calixteman force-pushed the split_merge_p2 branch 7 times, most recently from dda28b5 to 160fc39 Compare November 5, 2025 14:28
Copy link
Contributor

@timvandermeij timvandermeij left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me, with the final comment addressed, WIP removed from the commit message and passing tests. Looks good!

@calixteman calixteman changed the title [WIP] Update the page labels tree when a pdf is extracted (bug 1997379) Update the page labels tree when a pdf is extracted (bug 1997379) Nov 7, 2025
@calixteman
Copy link
Contributor Author

/botio browsertest

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Received

Command cmd_browsertest from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/5c5d0899f7bc177/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)


Received

Command cmd_browsertest from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/eaac3b1efe73260/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Failed

Full output at http://54.241.84.105:8877/5c5d0899f7bc177/output.txt

Total script time: 18.05 mins

  • Regression tests: FAILED
  different ref/snapshot: 1

Image differences available at: http://54.241.84.105:8877/5c5d0899f7bc177/reftest-analyzer.html#web=eq.log

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)


Failed

Full output at http://54.193.163.58:8877/eaac3b1efe73260/output.txt

Total script time: 32.58 mins

  • Regression tests: FAILED
  different ref/snapshot: 1

Image differences available at: http://54.193.163.58:8877/eaac3b1efe73260/reftest-analyzer.html#web=eq.log

@calixteman
Copy link
Contributor Author

I don't know why there's this difference...
It isn't related to this patch for sure.
The image is a bit complex so it's hard to debug something.
I do wonder if it could be due to a small variation with a floating number.
What puzzles me is that locally, if use the magnifying glass from devtools to get the color code, they look exactly the same when I take page 13 in tracemonkey compared with the extracted page.

@calixteman calixteman merged commit 57334bd into mozilla:master Nov 7, 2025
9 checks passed
@calixteman calixteman deleted the split_merge_p2 branch November 7, 2025 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants