Skip to content

Create the number tree for the ParentTree only one time #20425

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 7, 2025
Merged

Create the number tree for the ParentTree only one time #20425

merged 1 commit into from
Nov 7, 2025
+9 −4

Conversation

@calixteman
Copy link
Contributor

@calixteman calixteman commented Nov 5, 2025 •
edited
Loading

No description provided.

@calixteman
Copy link
Contributor Author

calixteman commented Nov 5, 2025

/botio test

@moz-tools-bot
Copy link
Collaborator

moz-tools-bot commented Nov 5, 2025

From: Bot.io (Linux m4)

Received

Command cmd_test from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/312a378477d7a19/output.txt

@moz-tools-bot
Copy link
Collaborator

moz-tools-bot commented Nov 5, 2025

From: Bot.io (Windows)

Received

Command cmd_test from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/cb4e12a01ad8e43/output.txt

@moz-tools-bot
Copy link
Collaborator

moz-tools-bot commented Nov 5, 2025

From: Bot.io (Windows)

Failed

Full output at http://54.193.163.58:8877/cb4e12a01ad8e43/output.txt

Total script time: 3.40 mins

  • Unit tests: FAILED
  • Integration Tests: FAILED
  • Regression tests: FAILED

Image differences available at: http://54.193.163.58:8877/cb4e12a01ad8e43/reftest-analyzer.html#web=eq.log

@calixteman calixteman force-pushed the only_parese_parenttree_one_time branch from 9ceb98b to b62d412 Compare November 5, 2025 16:31
@calixteman calixteman changed the title Only parse one time the ParentTree in the StructTreeRoot Create the number tree for the ParentTree only one time Nov 5, 2025
@calixteman calixteman force-pushed the only_parese_parenttree_one_time branch from b62d412 to 04db385 Compare November 5, 2025 16:50
timvandermeij
timvandermeij approved these changes Nov 6, 2025
View reviewed changes
Copy link
Contributor

@timvandermeij timvandermeij left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me, with passing tests. Thanks!

@timvandermeij
Copy link
Contributor

timvandermeij commented Nov 6, 2025

/botio test

@moz-tools-bot
Copy link
Collaborator

moz-tools-bot commented Nov 6, 2025

From: Bot.io (Linux m4)

Received

Command cmd_test from @timvandermeij received. Current queue size: 0

Live output at: http://54.241.84.105:8877/0a581de156f003e/output.txt

@moz-tools-bot
Copy link
Collaborator

moz-tools-bot commented Nov 6, 2025

From: Bot.io (Windows)

Received

Command cmd_test from @timvandermeij received. Current queue size: 0

Live output at: http://54.193.163.58:8877/3eb48954d8c9c32/output.txt

@moz-tools-bot
Copy link
Collaborator

moz-tools-bot commented Nov 6, 2025

From: Bot.io (Linux m4)

Success

Full output at http://54.241.84.105:8877/0a581de156f003e/output.txt

Total script time: 39.10 mins

  • Unit tests: Passed
  • Integration Tests: Passed
  • Regression tests: Passed

@moz-tools-bot
Copy link
Collaborator

moz-tools-bot commented Nov 6, 2025

From: Bot.io (Windows)

Success

Full output at http://54.193.163.58:8877/3eb48954d8c9c32/output.txt

Total script time: 78.88 mins

  • Unit tests: Passed
  • Integration Tests: Passed
  • Regression tests: Passed

@calixteman calixteman merged commit 2201777 into mozilla:master Nov 7, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@timvandermeij timvandermeij timvandermeij approved these changes

Assignees

No one assigned

Labels

core performance

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@calixteman @moz-tools-bot @timvandermeij