Handle commits with missing prs during landing setup#2696
Merged
lutien merged 2 commits intomozilla:masterfrom Jan 22, 2026
Merged
Conversation
lutien
force-pushed
the
handle-commits-with-missing-prs-during-landing-setup
branch
from
b9a3d13 to
31b030d
Compare
jgraham
requested changes
Jan 21, 2026
lutien
force-pushed
the
handle-commits-with-missing-prs-during-landing-setup
branch
from
eb9425c to
9478809
Compare
Member
Author
|
I've just realized that I have read the code wrong, and we actually have to abort even if the landing is not created yet. But I guess it's still fine if we just return the error message in the log. The PR is updated. |
jgraham
approved these changes
Jan 22, 2026
Member
jgraham
left a comment
jgraham
left a comment
There was a problem hiding this comment.
Thanks! LGTM with some minor fixups.
lutien
force-pushed
the
handle-commits-with-missing-prs-during-landing-setup
branch
from
eb8c832 to
bc04384
Compare
lutien
deleted the
handle-commits-with-missing-prs-during-landing-setup
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.