-
-
Notifications
You must be signed in to change notification settings - Fork 36k
Examples: More inspector usage. #31984
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
📦 Bundle sizeFull ESM build, minified and gzipped.
🌳 Bundle size after tree-shakingMinimal build including a renderer, camera, empty scene, and dependencies.
|
@sunag I was checking how to use the inspector, i noticed this pattern :
I think it would be cleaner if inspector variable is created at the global level with scene, camera etc..
|
TBH, it looks confusing to have two constructor calls. As long as the inspector isn't referenced outside |
sorry for the typo @Mugen87 i updated the code, of course it shoudn't be 2 constructors. I just feel this |
I like The Nothing against separating this into a variable, but it doesn't seem that necessary. |
Thanks @sunag , i will play with it and come back ! 👍 |
Description
More inspector usage and
RenderInspector
revisions.