Skip to content

Conversation

@sunag
Copy link
Collaborator

@sunag sunag commented Oct 29, 2025

Related issue: #32134

Description

This makes LightsNode, even though the file is unchanged in this PR, the same cache key for other passes, reusing the same TSL code generated when using different scenes, especially if .render(mesh, camera) is used.

@sunag sunag added this to the r181 milestone Oct 29, 2025
@github-actions
Copy link

📦 Bundle size

Full ESM build, minified and gzipped.

Before After Diff
WebGL 354.98
86.28
354.98
86.28
+0 B
+0 B
WebGPU 606.17
169.96
606.33
170
+162 B
+34 B
WebGPU Nodes 604.78
169.7
604.94
169.73
+162 B
+31 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

Before After Diff
WebGL 486.63
121.03
486.63
121.03
+0 B
+0 B
WebGPU 675.27
185.34
675.44
185.38
+162 B
+42 B
WebGPU Nodes 617.27
168.57
617.43
168.61
+162 B
+35 B

@sunag sunag marked this pull request as ready for review October 29, 2025 05:23
@sunag sunag merged commit e681ffb into mrdoob:dev Oct 29, 2025
10 checks passed
@sunag sunag deleted the dev-cachekey-fix-1 branch October 29, 2025 05:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant