Use a proper python package structure #52
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Python 3 version is kept. Python 2 removed.
Author
|
It should be noted that the convention with Python code these days is to be compatible with both py3 and py2 with the same codebase. To make sure that it's working in both environments there should be a test suite running tox or something similiar that tests multiple python versions. A CI tool like Travis CI is recommended to ensure that there are no regressions in Pull requests etc. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I removed the python 2 version and kept what was in the python3 package. If you still need the python2 folder you should create a branch for it instead of keeping it in a subdirectory. At least if you want to follow Python and Git conventions.