Fix for Python3 #61
Open
Fix for Python3 #61
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`create_NTLM_AUTHENTICATE_MESSAGE` and `create_NTLM_NEGOTIATE_MESSAGE` return already "decoded" `str` value, while this same double-`decode()` attempt results with `AttributeError: 'str' object has no attribute 'decode'` in Python3
|
I confirm it's necessary! |
|
FYI this was introduced by 5c8ccbd
But this isn't what I observe in debugger, due to: python-ntlm/python30/ntlm/ntlm.py Line 219 in 14e2243 python-ntlm/python30/ntlm/ntlm.py Line 337 in 14e2243 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
create_NTLM_AUTHENTICATE_MESSAGEandcreate_NTLM_NEGOTIATE_MESSAGEreturn already "decoded"strvalue, while this same double-decode()attempt results withAttributeError: 'str' object has no attribute 'decode'in Python3