Skip to content

Conversation

@Proxy-99
Copy link
Contributor

@Proxy-99 Proxy-99 commented Sep 7, 2024

closing #3215
added removeVehicleSirens() and addVehicleSirens()

test with client script

local vehicle = getPedOccupiedVehicle(localPlayer)

   local result =    addVehicleSirens(vehicle, 2, 3,false,true,true,false)
      setVehicleSirens(vehicle, 1, -0.3, 0, 0.8, 0, 0, 255, 255, 255)
      setVehicleSirens(vehicle, 2, 0.3, 0, 0.8, 255, 0, 0, 255, 255)
     setVehicleSirensOn(vehicle, true)

     print(result)

function remove ()
      removeVehicleSirens (vehicle)
end

     addCommandHandler("remove", remove)

@Proxy-99 Proxy-99 marked this pull request as ready for review September 8, 2024 14:46
@Proxy-99 Proxy-99 changed the title Adding function addVehicleSirens client-side Adding function addVehicleSirens & removeVehicleSirens client-side Sep 8, 2024
@Proxy-99 Proxy-99 requested a review from FileEX September 8, 2024 17:09
@Proxy-99 Proxy-99 requested review from FileEX and TracerDS September 8, 2024 17:58
@tederis tederis added the enhancement New feature or request label Sep 10, 2024
@Proxy-99 Proxy-99 requested a review from FileEX September 12, 2024 15:10
@Fernando-A-Rocha
Copy link
Contributor

What can we do about #1375?

tederis
tederis previously approved these changes Sep 14, 2024
@Fernando-A-Rocha
Copy link
Contributor

@Proxy-99 what's the state of this?😀

@Proxy-99
Copy link
Contributor Author

@Proxy-99 what's the state of this?😀

need someone to merge it

@Fernando-A-Rocha
Copy link
Contributor

i'm gonna test.

TheNormalnij
TheNormalnij previously approved these changes Oct 13, 2024
TheNormalnij
TheNormalnij previously approved these changes Oct 15, 2024
Copy link
Contributor

@Fernando-A-Rocha Fernando-A-Rocha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK to merge but should fix vehicle sirens not working on engineRequestModel ids on another PR

@Proxy-99
Copy link
Contributor Author

@TheNormalnij @tederis can u merge this

@TheNormalnij
Copy link
Member

@TheNormalnij @tederis can u merge this

Our build server doesn't work right now, and the next build is big enough.

@botder botder merged commit 682cdca into multitheftauto:master Dec 30, 2024
6 checks passed
@botder botder added this to the 1.6.1 milestone Dec 30, 2024
MTABot pushed a commit that referenced this pull request Dec 30, 2024
682cdca Adding client functions addVehicleSirens & removeVehicleSirens (PR #3704, Fixes #3215)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants