-
Notifications
You must be signed in to change notification settings - Fork 46
Changes for supernova release #677
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR prepares the SDK for the "supernova release" by introducing several changes to support new network features and improve transaction handling.
Changes:
- Added millisecond-precision block timestamp support via new
blockTimestampMsfield - Reduced default polling timeout from 6000ms to 600ms across account and transaction watchers
- Added support for "not-executable-in-block" transaction status as a failed state
- Consolidated timeout constants from hardcoded values to centralized constants
Reviewed changes
Copilot reviewed 7 out of 8 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| src/networkProviders/networkStatus.ts | Added blockTimestampMs field for millisecond timestamp precision |
| src/networkProviders/constants.ts | Reduced account polling timeout from 6000ms to 600ms |
| src/core/transactionWatcher.ts | Refactored to use centralized constants instead of hardcoded timeout values |
| src/core/transactionWatcher.spec.ts | Added test coverage for "not-executable-in-block" status |
| src/core/transactionStatus.ts | Added "not-executable-in-block" as a failed transaction status |
| src/core/constants.ts | Defined new transaction awaiting timeout constants |
| package.json | Bumped version to 15.4.0 |
| package-lock.json | Updated version lockfile to 15.4.0 |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
src/core/transactionStatus.ts
Outdated
| this.status == "failed" || | ||
| this.status == "unsuccessful" || | ||
| this.isInvalid() || | ||
| this.status == "not-executable-in-block" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this correct for the unexecutable to be reported as failed?
this was not executed, similar to higher nonce or lower nonce in transaction.
It may be executed in a different block afterwards (for higher nonce for example, if the gap is filled)
No description provided.