Skip to content

Conversation

@popenta
Copy link
Contributor

@popenta popenta commented Feb 2, 2026

No description provided.

@popenta popenta self-assigned this Feb 2, 2026
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR prepares the SDK for the "supernova release" by introducing several changes to support new network features and improve transaction handling.

Changes:

  • Added millisecond-precision block timestamp support via new blockTimestampMs field
  • Reduced default polling timeout from 6000ms to 600ms across account and transaction watchers
  • Added support for "not-executable-in-block" transaction status as a failed state
  • Consolidated timeout constants from hardcoded values to centralized constants

Reviewed changes

Copilot reviewed 7 out of 8 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
src/networkProviders/networkStatus.ts Added blockTimestampMs field for millisecond timestamp precision
src/networkProviders/constants.ts Reduced account polling timeout from 6000ms to 600ms
src/core/transactionWatcher.ts Refactored to use centralized constants instead of hardcoded timeout values
src/core/transactionWatcher.spec.ts Added test coverage for "not-executable-in-block" status
src/core/transactionStatus.ts Added "not-executable-in-block" as a failed transaction status
src/core/constants.ts Defined new transaction awaiting timeout constants
package.json Bumped version to 15.4.0
package-lock.json Updated version lockfile to 15.4.0

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

mradian1
mradian1 previously approved these changes Feb 2, 2026
this.status == "failed" ||
this.status == "unsuccessful" ||
this.isInvalid() ||
this.status == "not-executable-in-block"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this correct for the unexecutable to be reported as failed?

this was not executed, similar to higher nonce or lower nonce in transaction.
It may be executed in a different block afterwards (for higher nonce for example, if the gap is filled)

@popenta popenta merged commit b2d8b7e into main Feb 10, 2026
5 checks passed
@popenta popenta deleted the supernova-changes branch February 10, 2026 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants