fix: align default values of map UI option props with Naver Map SDK #141
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
What does this change?
🇰🇷 한국어
React Native New Architecture에서 네이티브 지도 컴포넌트(RNCNaverMapView)의 스펙을 정의하는 코드젠용 spec 파일인 `src/spec/RNCNaverMapViewNativeComponent.ts' 에서 props 타입을 boolean 으로만 정의하게 되면 해당 props 의 기본값이 c++ 의 기본형에 따라 false 로 지정됩니다.
지도 첫 렌더 시 몇몇 props 에 false 로 설정하면 앞에서 c++에 설정된 기본값과 같아 실제 sdk 에 false 로 설정하지 않습니다.
그러나 sdk 의 기본 값은 true 이기 때문에 props 가 반영되지 않는 것 처럼 보이는 버그를 수정합니다.
English
In the codegen spec file src/spec/RNCNaverMapViewNativeComponent.ts, which defines the spec for the native map component (RNCNaverMapView) in React Native New Architecture, if a prop is defined as a boolean type, its default value is set to false according to the C++ primitive type default. When the map is first rendered, if some props are set to false, this matches the default value in C++, so the value is not actually set in the underlying SDK.However, since the SDK’s default value is true, this causes a bug where the prop appears not to be applied.
See also: #130 (comment)