Skip to content

Conversation

benburkert
Copy link
Contributor

A proof-of-concept to add a custom CA option to iroh-gateway, along with EAB token support for CAs like anchor.dev and zerossl.

@rklaehn
Copy link
Contributor

rklaehn commented Apr 4, 2025

Thanks for the PR, and sorry that we didn't look at this earlier.

So the use case is to be able to run a gateway without a letsencrypt CA? It does not add any additional deps, and the code looks simple enough, so as soon as the git dep is gone it seems that we can merge this.

@benburkert
Copy link
Contributor Author

Thanks for the PR, and sorry that we didn't look at this earlier.

No worries, thanks for getting to it!

So the use case is to be able to run a gateway without a letsencrypt CA?

Yep, and be able to use a CA that requires EAB tokens like ZeroSSL.

as soon as the git dep is gone it seems that we can merge this.

The git dep still required until you release a new version of tokio-rustls-acme. I've updated it to use the latest commit on main.

@rklaehn
Copy link
Contributor

rklaehn commented Apr 7, 2025

Thanks for the PR, and sorry that we didn't look at this earlier.

No worries, thanks for getting to it!

So the use case is to be able to run a gateway without a letsencrypt CA?

Yep, and be able to use a CA that requires EAB tokens like ZeroSSL.

as soon as the git dep is gone it seems that we can merge this.

The git dep still required until you release a new version of tokio-rustls-acme. I've updated it to use the latest commit on main.

Overlooked that this crate is one of ours... 😊 . Will see what I can do.

@ramfox
Copy link
Member

ramfox commented Apr 7, 2025

@benburkert tokio-rustls-acme v0.7.0 has been released! Thanks for bringing it to our attention 🙌

@benburkert
Copy link
Contributor Author

thanks @ramfox, i just rebased in v0.7.0 so I think this is ready.

@ramfox ramfox merged commit 4511de4 into n0-computer:main Apr 11, 2025
1 check passed
@github-project-automation github-project-automation bot moved this from 🏗 In progress to ✅ Done in iroh Apr 11, 2025
@ramfox
Copy link
Member

ramfox commented Apr 11, 2025

@benburkert wonderful! it's in 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

3 participants