feat(iroh): Enable netwatch::netmon::Monitor and the metrics feature in Wasm
#3206
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…`ActorSocketState::msock_socket_state`
matheus23
force-pushed
the
matheus23/use-netwatch-wasm
branch
from
8a5e6d0 to
b02cd72
Compare
|
Documentation for this PR has been generated and is available at: https://n0-computer.github.io/iroh/pr/3206/docs/iroh/ Last updated: 2025-03-04T15:25:15Z |
matheus23
force-pushed
the
matheus23/use-netwatch-wasm
branch
from
6a14931 to
7ba2ac8
Compare
dignifiedquire
approved these changes
Mar 4, 2025
Contributor
dignifiedquire
left a comment
dignifiedquire
left a comment
There was a problem hiding this comment.
looks good, modulo the patch stuff
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
netwatchdependency in Wasmnetwatch::netmon::Monitorinmagicsock::Actormetricsfeature for Wasm by depending on a newer iroh-metricsnetwatch::ip::is_unicast_link_local, as we can depend on that in Wasm again now.Notes & open questions
There's some dependencies:
magicsock::SocketStateandActorSocketState#3203 to be merged firstiroh-metricsmain branch (I.e. feat!: Split up themetricsfeature intometricsandserviceiroh-metrics#11 being released)Closes #3195
Change checklist