-
Notifications
You must be signed in to change notification settings - Fork 302
feat: add a builder for DnsResolver #3475
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Documentation for this PR has been generated and is available at: https://n0-computer.github.io/iroh/pr/3475/docs/iroh/ Last updated: 2025-09-30T09:13:25Z |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice
aadafde
to
8088c2a
Compare
I pushed a commit that has no functional changes, but makes it more obvious in the code that if we fail to load the host system's DNS config, we fallback to |
Description
Based on #3473
In addition to the trait added in #3473 ,this adds a builder to allow setting more than one custom nameserver on the default hickory resolver, and to allow using other protocols than UDP.
The additional protocols are DNS over TCP, TLS, and HTTPS. For the latter two I enabled the
https
feature ofhickory-resolver
- this doesn't add any new dependencies, as tokio-rustls and h2 are in the tree already through reqwest.Breaking Changes
Notes & open questions
There's two more protocols supported by hickory though behind non-default feature flags: Quic and H3. If there's demand, we could enable those too.
Change checklist
quic-rpc
iroh-gossip
iroh-blobs
dumbpipe
sendme