examples: improve bench example #24
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Frando
added a commit
that referenced
this pull request
Jun 20, 2025
This makes the `Sender` be `Clone` and take `&self` in the methods. For the remote sender, this is achieved by putting the actual send stream and buffer into a `tokio::sync::Mutex`. We also ensure that if sending failed on one sender, subsequent sends on cloned senders will fail as well. And if a `send` future is dropped before completion, further sends will fail as well, as we cannot guarantee integrity of the send stream anymore if a send future was dropped. ## Breaking changes The methods from `Sender` all take `&self` instead of `&mut self`. ## Notes and open questions My quick benchmark shows some weird numbers: ``` Local bench RPC seq 128_996 rps RPC par 1_093_166 rps bidi seq 4_281_373 rps Remote bench RPC seq 11_393 rps RPC par 60_073 rps bidi seq 1_480_826 rps Reference bench Reference seq 139_889 rps Reference par 2_784_308 rps ``` Compared to #24 the `bidi seq` for remote got *much* faster. I can't really explain that? But I ran quite a few times, without much change on either `Frando/improve-bench` or `Frando/clone-sender`. Fixes #23
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds remote usage to the benchmark in the
computeexample.Results: