Skip to content

Conversation

Frando
Copy link
Member

@Frando Frando commented Sep 26, 2025

A couple of fixes for things I noticed recently:

  • Set a keepalive interval on the client transport config when using the quinn transport with the helpers from the util method. Without this, a connection times out if no rpc calls are issued for 30s (default idle timeout)
  • Improve the listen helper functions for both irpc and irpc_iroh:
    • Add remote address to log lines
    • Log errors from handle_connection
    • Poll the JoinSet for finished tasks, otherwise the result list in the join set grows unbounded over time
  • Fix the tracing_subscriber setup call in the examples

@Frando Frando requested a review from rklaehn September 26, 2025 08:17
Copy link
Collaborator

@rklaehn rklaehn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. The listen loops were in need of some love. I think I mentioned it in some issue somewhere, but can't find it.

@Frando Frando merged commit 99df1dd into main Sep 26, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants