Skip to content

feat(netwatch, portmapper): Switch from thiserror to snafu #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
May 5, 2025
Merged

feat(netwatch, portmapper): Switch from thiserror to snafu #24

Show file tree
Hide file tree
Changes from 9 commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
5f6c7c1
feat(portmapper): Convert to snafu-based errors
matheus23 May 2, 2025
74f75b8
Always use correct `snafu(visibility)`
matheus23 May 2, 2025
7216eaf
feat(netwatch): Attempt to switch to snafu
matheus23 May 2, 2025
f185d18
Some android fixes
matheus23 May 2, 2025
dfc64dd
Try fixing more bsd code
matheus23 May 2, 2025
5cdbeec
Try fixing windows?
matheus23 May 2, 2025
18252c4
Try to fix more stuff
matheus23 May 2, 2025
0d402ab
fixups
matheus23 May 2, 2025
214b7fd
fixups
matheus23 May 2, 2025
2091aba
Address review
matheus23 May 5, 2025
37e1b77
fixups
matheus23 May 5, 2025
d35bca0
Make sure to add backtrace to all fields
matheus23 May 5, 2025
2df5400
Update nested_enum_utils
matheus23 May 5, 2025
ba278ef
fix compliation
matheus23 May 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
103 changes: 99 additions & 4 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

7 changes: 6 additions & 1 deletion netwatch/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,9 @@ workspace = true
atomic-waker = "1.1.2"
bytes = "1.7"
n0-future = "0.1.1"
thiserror = "2"
n0-snafu = { git = "https://github.com/n0-computer/n0-snafu", branch = "matheus23/clone" }
nested_enum_utils = "0.2.0"
snafu = "0.8.5"
time = "0.3.20"
tokio = { version = "1", features = [
"io-util",
Expand Down Expand Up @@ -60,6 +62,7 @@ netlink-packet-core = "0.7.0"
netlink-packet-route = "0.19" # 0.20/21 is blocked on rtnetlink bumping its dependency
netlink-sys = "0.8.6"
rtnetlink = "=0.13.1" # pinned because of https://github.com/rust-netlink/rtnetlink/issues/83
derive_more = { version = "1.0.0", features = ["display"] }

[target.'cfg(target_os = "windows")'.dependencies]
wmi = "0.14"
Expand All @@ -68,7 +71,9 @@ windows-result = "0.3"
serde = { version = "1", features = ["derive"] }
derive_more = { version = "1.0.0", features = ["debug"] }

# wasm-in-browser dependencies
[target.'cfg(all(target_family = "wasm", target_os = "unknown"))'.dependencies]
derive_more = { version = "1.0.0", features = ["display"] }
js-sys = "0.3"
web-sys = { version = "0.3.70", features = ["EventListener", "EventTarget"] }

Expand Down
Loading
Loading