Skip to content

Conversation

dignifiedquire
Copy link
Contributor

@dignifiedquire dignifiedquire commented Oct 17, 2025

TODO: figure out how renewing works

Fixes #52

@dignifiedquire dignifiedquire changed the title fix(portmapper): use 2hours as lease duration fix(portmapper): UPNP use 2hours as lease duration Oct 17, 2025
Copy link

Documentation for this PR has been generated and is available at: https://n0-computer.github.io/net-tools/pr/53/docs/net_tools/

Last updated: 2025-10-17T14:34:15Z

@n0bot n0bot bot added this to iroh Oct 17, 2025
@github-project-automation github-project-automation bot moved this to 🏗 In progress in iroh Oct 17, 2025
Copy link
Contributor

@divagant-martian divagant-martian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even with the infinite lifetime, we handle a 1h half lifetime, after which the mapping is renewed, so I don't think you need to do anything else beside what's in the PR to ensure mappings are always present, given the router allows it

@dignifiedquire
Copy link
Contributor Author

cool, will merge then as is

@dignifiedquire dignifiedquire merged commit c9f2f81 into main Oct 20, 2025
29 checks passed
@github-project-automation github-project-automation bot moved this from 🏗 In progress to ✅ Done in iroh Oct 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

UPnP infinite lease duration causes port mapping failure.

2 participants