updating errored flag, on change of error message #228#328
Open
akshayjai1 wants to merge 5 commits inton4kz:masterfrom
Open
updating errored flag, on change of error message #228#328akshayjai1 wants to merge 5 commits inton4kz:masterfrom
akshayjai1 wants to merge 5 commits inton4kz:masterfrom
Conversation
Fix issue n4kz#228 This component was missing componentDidUpdate and therefore error message was not visible after we submit the form, the error was comming, but the flag stored in state, was not being updated. We are updating this.state.errored with this commit.
|
Hi @akshayjai1 I would suggest just using |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix issue #228
This component was missing componentDidUpdate and therefore errored state was not updating on update of this.props.error and
thus error message was not visible after we submit the form
We are updating this.state.errored with this commit.