Merged
Conversation
Bumps nanoFramework.Iot.Device.Ws28xx.Esp32 from 1.2.907 to 1.2.955</br>Bumps nanoFramework.Iot.Device.Mpu6886 from 1.2.907 to 1.2.952</br>Bumps nanoFramework.Iot.Device.Buzzer from 1.2.931 to 1.2.952</br>Bumps nanoFramework.Iot.Device.Rtc from 1.2.907 to 1.2.952</br>Bumps nanoFramework.Iot.Device.Ip5306 from 1.2.931 to 1.2.952</br>Bumps nanoFramework.Iot.Device.Axp192 from 1.2.931 to 1.2.952</br> [version update] ###⚠️ This is an automated update.⚠️
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (26)
📒 Files selected for processing (13)
🚧 Files skipped from review as they are similar to previous changes (3)
WalkthroughThis PR updates many Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Tip Try Coding Plans. Let us write the prompt for your AI agent so you can ship faster (with fewer bugs). Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 3
🧹 Nitpick comments (2)
Tests/FireTestApp/packages.lock.json (1)
167-202: Same dual UnitsNet package pattern observed.This file exhibits the same pattern as
M5StickTestApp/packages.lock.jsonwith bothnanoFramework.UnitsNet.*(5.76.15) andUnitsNet.nanoFramework.*(5.75.0) packages. Same cleanup consideration applies if the older namespace is being deprecated.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@Tests/FireTestApp/packages.lock.json` around lines 167 - 202, The packages.lock.json lists duplicate UnitsNet packages under two namespaces (nanoFramework.UnitsNet.* at 5.76.15 and UnitsNet.nanoFramework.* at 5.75.0); remove or consolidate the older/deprecated namespace entries (UnitsNet.nanoFramework.ElectricCurrent, UnitsNet.nanoFramework.Frequency, UnitsNet.nanoFramework.Temperature) and ensure the project references and csproj package references point to the intended packages (nanoFramework.UnitsNet.*) at the correct version (5.76.15), then regenerate lock file (restore/nuget restore) so only the correct package entries remain.Tests/M5StickTestApp/packages.lock.json (1)
125-172: Consider whether both UnitsNet package variants are needed.The file now contains both naming conventions for the same unit types:
nanoFramework.UnitsNet.*at 5.76.15 (newly added)UnitsNet.nanoFramework.*at 5.75.0 (pre-existing)If
nanoFramework.UnitsNet.*is the new canonical package namespace replacingUnitsNet.nanoFramework.*, consider removing the older packages in a follow-up to reduce dependency bloat.nanoFramework UnitsNet package migration from UnitsNet.nanoFramework🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@Tests/M5StickTestApp/packages.lock.json` around lines 125 - 172, The lockfile contains both package families nanoFramework.UnitsNet.* (5.76.15) and the older UnitsNet.nanoFramework.* (5.75.0); if the project has migrated to the nanoFramework.UnitsNet packages, remove the old UnitsNet.nanoFramework.* entries from the lockfile and from any package references in project files (e.g., csproj) to avoid duplicate dependencies, then restore/restore-packages so the lockfile regenerates; if you need to keep both temporarily, explicitly align versions or add a note in the PR explaining why the older UnitsNet.nanoFramework.* packages must remain.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@nanoFramework.CoreInk/packages.lock.json`:
- Around line 107-118: The lock file shows conflicting package families:
nanoFramework.UnitsNet.Frequency and nanoFramework.UnitsNet.Temperature
(v5.76.15) coexisting with the old UnitsNet.nanoFramework.Frequency and
UnitsNet.nanoFramework.Temperature (v5.75.0) as "type":"Direct"; find which
project/PackageReference or upstream package is bringing in the old
UnitsNet.nanoFramework.* packages, update those PackageReference entries (or
update the upstream package versions) to use the nanoFramework.UnitsNet.* family
(or a single consistent version), remove any direct references to the old
UnitsNet.nanoFramework.* packages, then run restore/lockfile regeneration
(dotnet restore) so the lock file contains only the chosen family (verify
presence of nanoFramework.UnitsNet.Frequency / Temperature and removal of
UnitsNet.nanoFramework.*).
In `@nanoFramework.M5Core2/packages.lock.json`:
- Around line 191-214: Remove the unused UnitsNet package families: delete all
nanoFramework.UnitsNet.* (e.g., nanoFramework.UnitsNet.ElectricCurrent,
.ElectricPotential, .Power, .Temperature) and all UnitsNet.nanoFramework.*
entries from packages.config and remove their corresponding <PackageReference> /
<Reference> entries in the project file (nanoFramework.M5Core2.nfproj); then run
the restore/lockfile regeneration (nuget/dotnet restore or your repo's restore
script) to recreate packages.lock.json without those packages and commit the
updated packages.config, .nfproj, and packages.lock.json.
In `@Tests/ToughTestApp/packages.lock.json`:
- Around line 119-142: The project currently references duplicate unit packages:
keep the newer nanoFramework.UnitsNet.* packages
(nanoFramework.UnitsNet.ElectricCurrent, .ElectricPotential, .Power,
.Temperature at 5.76.15) and remove the older UnitsNet.nanoFramework.* entries
(UnitsNet.nanoFramework.ElectricCurrent, .ElectricPotential, .Power,
.Temperature at 5.75.0) from both packages.config (or packages.lock.json) and
the .nfproj References so only the nanoFramework.UnitsNet.* packages remain;
update/remove any <PackageReference> or <Reference> nodes and package entries
that match the old UnitsNet.nanoFramework.* identifiers to eliminate the
duplicates.
---
Nitpick comments:
In `@Tests/FireTestApp/packages.lock.json`:
- Around line 167-202: The packages.lock.json lists duplicate UnitsNet packages
under two namespaces (nanoFramework.UnitsNet.* at 5.76.15 and
UnitsNet.nanoFramework.* at 5.75.0); remove or consolidate the older/deprecated
namespace entries (UnitsNet.nanoFramework.ElectricCurrent,
UnitsNet.nanoFramework.Frequency, UnitsNet.nanoFramework.Temperature) and ensure
the project references and csproj package references point to the intended
packages (nanoFramework.UnitsNet.*) at the correct version (5.76.15), then
regenerate lock file (restore/nuget restore) so only the correct package entries
remain.
In `@Tests/M5StickTestApp/packages.lock.json`:
- Around line 125-172: The lockfile contains both package families
nanoFramework.UnitsNet.* (5.76.15) and the older UnitsNet.nanoFramework.*
(5.75.0); if the project has migrated to the nanoFramework.UnitsNet packages,
remove the old UnitsNet.nanoFramework.* entries from the lockfile and from any
package references in project files (e.g., csproj) to avoid duplicate
dependencies, then restore/restore-packages so the lockfile regenerates; if you
need to keep both temporarily, explicitly align versions or add a note in the PR
explaining why the older UnitsNet.nanoFramework.* packages must remain.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 62f2f24c-4e07-4ecc-901d-a0e1cf789c3f
⛔ Files ignored due to path filters (41)
Tests/AtomLiteTestApp/AtomLiteTestApp.nfprojis excluded by none and included by noneTests/AtomLiteTestApp/packages.configis excluded by none and included by noneTests/AtomMatrixTestApp/AtomMatrixTestApp.nfprojis excluded by none and included by noneTests/AtomMatrixTestApp/packages.configis excluded by none and included by noneTests/FireTestApp/FireTestApp.nfprojis excluded by none and included by noneTests/FireTestApp/packages.configis excluded by none and included by noneTests/M5Core2TestApp/M5Core2TestApp.nfprojis excluded by none and included by noneTests/M5Core2TestApp/packages.configis excluded by none and included by noneTests/M5CoreTestApp/M5CoreTestApp.nfprojis excluded by none and included by noneTests/M5CoreTestApp/packages.configis excluded by none and included by noneTests/M5StickTestApp/M5StickTestApp.nfprojis excluded by none and included by noneTests/M5StickTestApp/packages.configis excluded by none and included by noneTests/ToughTestApp/ToughTestApp.nfprojis excluded by none and included by noneTests/ToughTestApp/packages.configis excluded by none and included by nonenanoFramework.AtomLite.nuspecis excluded by none and included by nonenanoFramework.AtomLite/nanoFramework.AtomLite.nfprojis excluded by none and included by nonenanoFramework.AtomLite/packages.configis excluded by none and included by nonenanoFramework.AtomMatrix.nuspecis excluded by none and included by nonenanoFramework.AtomMatrix/nanoFramework.AtomMatrix.nfprojis excluded by none and included by nonenanoFramework.AtomMatrix/packages.configis excluded by none and included by nonenanoFramework.CoreInk.nuspecis excluded by none and included by nonenanoFramework.CoreInk/nanoFramework.CoreInk.nfprojis excluded by none and included by nonenanoFramework.CoreInk/packages.configis excluded by none and included by nonenanoFramework.Fire.nuspecis excluded by none and included by nonenanoFramework.Fire/nanoFramework.Fire.nfprojis excluded by none and included by nonenanoFramework.Fire/packages.configis excluded by none and included by nonenanoFramework.M5Core.nuspecis excluded by none and included by nonenanoFramework.M5Core/nanoFramework.M5Core.nfprojis excluded by none and included by nonenanoFramework.M5Core/packages.configis excluded by none and included by nonenanoFramework.M5Core2.nuspecis excluded by none and included by nonenanoFramework.M5Core2/nanoFramework.M5Core2.nfprojis excluded by none and included by nonenanoFramework.M5Core2/packages.configis excluded by none and included by nonenanoFramework.M5StickC.nuspecis excluded by none and included by nonenanoFramework.M5StickC/nanoFramework.M5StickC.nfprojis excluded by none and included by nonenanoFramework.M5StickC/packages.configis excluded by none and included by nonenanoFramework.M5StickCPlus.nuspecis excluded by none and included by nonenanoFramework.M5StickCPlus/nanoFramework.M5StickCPlus.nfprojis excluded by none and included by nonenanoFramework.M5StickCPlus/packages.configis excluded by none and included by nonenanoFramework.Tough.nuspecis excluded by none and included by nonenanoFramework.Tough/nanoFramework.Tough.nfprojis excluded by none and included by nonenanoFramework.Tough/packages.configis excluded by none and included by none
📒 Files selected for processing (16)
Tests/AtomLiteTestApp/packages.lock.jsonTests/AtomMatrixTestApp/packages.lock.jsonTests/FireTestApp/packages.lock.jsonTests/M5Core2TestApp/packages.lock.jsonTests/M5CoreTestApp/packages.lock.jsonTests/M5StickTestApp/packages.lock.jsonTests/ToughTestApp/packages.lock.jsonnanoFramework.AtomLite/packages.lock.jsonnanoFramework.AtomMatrix/packages.lock.jsonnanoFramework.CoreInk/packages.lock.jsonnanoFramework.Fire/packages.lock.jsonnanoFramework.M5Core/packages.lock.jsonnanoFramework.M5Core2/packages.lock.jsonnanoFramework.M5StickC/packages.lock.jsonnanoFramework.M5StickCPlus/packages.lock.jsonnanoFramework.Tough/packages.lock.json
|
nfbot
deleted the
nfbot/update-dependencies/8942def5-1179-43f2-8a2f-0f9ebbb08aa0
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps nanoFramework.Iot.Device.Ws28xx.Esp32 from 1.2.907 to 1.2.955
Bumps nanoFramework.Iot.Device.Mpu6886 from 1.2.907 to 1.2.952
Bumps nanoFramework.Iot.Device.Buzzer from 1.2.931 to 1.2.952
Bumps nanoFramework.Iot.Device.Rtc from 1.2.907 to 1.2.952
Bumps nanoFramework.Iot.Device.Ip5306 from 1.2.931 to 1.2.952
Bumps nanoFramework.Iot.Device.Axp192 from 1.2.931 to 1.2.952
[version update]
Summary by CodeRabbit