Skip to content

Conversation

@Czaki
Copy link
Collaborator

@Czaki Czaki commented Aug 12, 2025

References and relevant issues

pyapp-kit/app-model#258 (comment)
followup #8067

Description

The pytest-qt in version 4.5.0 dropped the support for PySide2. In #8067 I've fixed it on our side, but tests of critical for us pyapp-kit projects are broken. This PR fixes their test that uses https://github.com/pyapp-kit/workflows/blob/main/.github/workflows/test-dependents.yml

@Czaki Czaki added this to the 0.6.4 milestone Aug 12, 2025
@Czaki Czaki requested a review from a team as a code owner August 12, 2025 12:10
@Czaki Czaki added the maintenance PR with maintance changes, label Aug 12, 2025
@Czaki Czaki added the ready to merge Last chance for comments! Will be merged in ~24h label Aug 12, 2025
@codecov
Copy link

codecov bot commented Aug 12, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.03%. Comparing base (db02d84) to head (c0a85a8).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8205      +/-   ##
==========================================
+ Coverage   92.96%   93.03%   +0.07%     
==========================================
  Files         658      658              
  Lines       62604    62604              
==========================================
+ Hits        58201    58245      +44     
+ Misses       4403     4359      -44     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Czaki Czaki merged commit 5c653f2 into napari:main Aug 12, 2025
85 of 89 checks passed
@Czaki Czaki deleted the pin_pytest-qt branch August 12, 2025 17:35
@github-actions github-actions bot removed the ready to merge Last chance for comments! Will be merged in ~24h label Aug 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

maintenance PR with maintance changes,

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants