Skip to content

Conversation

jvigliotta
Copy link
Contributor

@jvigliotta jvigliotta commented Aug 26, 2025

Closes #8082
Closes #8083

Describe your changes:

Adds the ability to evaluate conditions historically.

Majority of the work completed by @khalidadil

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Is this a notable change that will require a special callout in the release notes? For example, will this break compatibility with existing APIs or projects that consume these plugins?

Author Checklist

  • Changes address original issue?
  • Tests included and/or updated with changes?
  • Has this been smoke tested?
  • Have you associated this PR with a type: label? Note: this is not necessarily the same as the original issue.
  • Have you associated a milestone with this PR? Note: leave blank if unsure.
  • Testing instructions included in associated issue OR is this a dependency/testcase change?

Reviewer Checklist

  • Changes appear to address issue?
  • Reviewer has tested changes by following the provided instructions?
  • Changes appear not to be breaking changes?
  • Appropriate automated tests included?
  • Code style and in-line documentation are appropriate?

@jvigliotta
Copy link
Contributor Author

supersedes #7868

return historicalTelemetryDateMap;
}

self.onmessage = function (e) {

Check warning

Code scanning / CodeQL

Missing origin verification in `postMessage` handler Medium

Postmessage handler has no origin check.

Copilot Autofix

AI about 20 hours ago

Copilot could not generate an autofix suggestion

Copilot could not generate an autofix suggestion for this alert. Try pushing a new commit or if the problem persists contact support.

@jvigliotta jvigliotta added the type:feature Feature. Required intentional design label Aug 26, 2025
@jvigliotta jvigliotta added this to the 4.1.1 milestone Aug 26, 2025
Copy link

codecov bot commented Aug 26, 2025

Codecov Report

❌ Patch coverage is 2.80374% with 208 lines in your changes missing coverage. Please review.
✅ Project coverage is 50.43%. Comparing base (2494e2f) to head (d9cc238).

Files with missing lines Patch % Lines
...c/plugins/condition/HistoricalTelemetryProvider.js 0.00% 129 Missing ⚠️
src/plugins/condition/ConditionManager.js 0.00% 56 Missing ⚠️
...lugins/condition/ConditionInspectorViewProvider.js 18.18% 9 Missing ⚠️
.../plugins/condition/ConditionSetMetadataProvider.js 0.00% 7 Missing ⚠️
...gins/plot/stackedPlot/mixins/objectStyles-mixin.js 0.00% 5 Missing ⚠️
...plugins/condition/ConditionSetTelemetryProvider.js 0.00% 2 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (2494e2f) and HEAD (d9cc238). Click for more details.

HEAD has 6 uploads less than BASE
Flag BASE (2494e2f) HEAD (d9cc238)
unit 1 0
e2e-ci 8 3
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8148      +/-   ##
==========================================
- Coverage   56.67%   50.43%   -6.24%     
==========================================
  Files         704      459     -245     
  Lines       28283    14281   -14002     
  Branches     2770        0    -2770     
==========================================
- Hits        16028     7203    -8825     
+ Misses      11909     7078    -4831     
+ Partials      346        0     -346     
Flag Coverage Δ
e2e-ci 50.33% <2.80%> (-12.81%) ⬇️
e2e-full 23.38% <1.86%> (-0.31%) ⬇️
unit ?
Files with missing lines Coverage Δ
src/plugins/condition/plugin.js 72.72% <100.00%> (-27.28%) ⬇️
src/plugins/condition/utils/constants.js 100.00% <100.00%> (ø)
src/plugins/plot/tickUtils.js 74.64% <100.00%> (-22.54%) ⬇️
...plugins/condition/ConditionSetTelemetryProvider.js 14.28% <0.00%> (-80.72%) ⬇️
...gins/plot/stackedPlot/mixins/objectStyles-mixin.js 35.41% <0.00%> (-49.69%) ⬇️
.../plugins/condition/ConditionSetMetadataProvider.js 16.66% <0.00%> (-83.34%) ⬇️
...lugins/condition/ConditionInspectorViewProvider.js 18.18% <18.18%> (ø)
src/plugins/condition/ConditionManager.js 0.00% <0.00%> (-87.57%) ⬇️
...c/plugins/condition/HistoricalTelemetryProvider.js 0.00% <0.00%> (ø)

... and 442 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2494e2f...d9cc238. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jvigliotta jvigliotta requested a review from akhenry August 27, 2025 20:42
@jvigliotta jvigliotta marked this pull request as ready for review August 27, 2025 23:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:feature Feature. Required intentional design
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support a mode where Condition Sets emit the underlying telemetry value when true Support conditional evaluation of historical telemetry
2 participants