Properly unsubscribe from dispatcher subject #1483
Merged
+55
−38
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
scottf
commented
Nov 19, 2025
scottf
commented
- Dispatcher unsubscribe by subject would unsubscribe all subject, not just target subject
* Dispatcher unsubscribe by subject would unsubscribe all subject, not just target subject
scottf
commented
Nov 19, 2025
| } | ||
|
|
||
| @Test | ||
| public void testDispatcherMultipleSubscriptionsBySubject() throws Exception { |
Contributor
Author
There was a problem hiding this comment.
Moved this to dispatcher test
scottf
commented
Nov 19, 2025
|
|
||
| public class DispatcherTests { | ||
| @Test | ||
| public void testDispatcherMultipleSubscriptionsBySubject() throws Exception { |
Contributor
Author
There was a problem hiding this comment.
updated test to dispatcher subscribe to multiple subjects, then unsubscribe from only one, making sure that only the one subject was unsubscribed.
Ran the test against the old code, it failed as expected, against the new code it passes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.