-
Notifications
You must be signed in to change notification settings - Fork 232
uv + nats-server package changes #745
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
6da65ae to
35ded54
Compare
|
@wallyqs why we want to move it back to nats package? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Heya, so this seems to undo the addition of workspaces?
Keeping nats-server as its own package is beneficial for both us and the ecosystem, it's its own little standalone thing that exists without knowledge of anything but the existence of the nats-server binary being in path and some of its options.
Avoids cyclical dependencies for us as-well, easy to depend on siblings, hard to depend on a manifest package.
Signed-off-by: Waldemar Quevedo <[email protected]>
840e3c5 to
bbea82a
Compare
|
Updated to keep the workspace and instead only changed the import to |
|
Follow up from a couple of the previous PRs:
nats-serverpackage fromimport nats.serverintoimport nats.testing.serverinstead