Add first_seq support to StreamConfig
#779
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Casper Beyer <[email protected]>
caspervonb
changed the title
first_seq support to StreamConfig
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for the first_seq stream configuration parameter, which allows specifying a custom starting sequence number when creating a JetStream stream. This feature was introduced in nats-server 2.10.0.
- Added
first_seqoptional field toStreamConfigclass in the API - Implemented comprehensive test coverage for the
first_seqfunctionality
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| nats/src/nats/js/api.py | Added first_seq optional field to StreamConfig with appropriate documentation indicating it was introduced in nats-server 2.10.0 |
| nats/tests/test_js.py | Added test_stream_first_seq test method to verify stream creation with custom starting sequence, message publishing with correct sequence numbers, and message retrieval by sequence |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially resolves #760