Skip to content

Conversation

@Ferrany1
Copy link

@Ferrany1 Ferrany1 commented Oct 31, 2025

#1481 1481

@Jarema
Copy link
Member

Jarema commented Nov 4, 2025

@Ferrany1 thanks for the contribution.

However, not only it is a breaking change for not practical reason.
This is common pattern in Rust to have cheaply clone'able handle.

This also introduces some lifetime problems.

@caspervonb
Copy link
Collaborator

Not sure what the motivation is, since client is clonable?

Could have:

fn client_ref(&self) -> &Client;

But would have to be tied to lifetime of self.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants