-
Couldn't load subscription status.
- Fork 43
[New component] InlineMessage #4185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: 1634cb0 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR introduces a new InlineMessage component that replaces the inline variant of the existing Alert component. The component provides contextual messages with icon support and multiple variants (info, success, warning, error).
Key changes:
- New React component with icon integration and size variants
- Complete CSS styling for both standard and darkside themes
- Storybook stories demonstrating all component features
Reviewed Changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
@navikt/core/react/src/inline-message/root/InlineMessage.tsx |
Main React component implementation with variant and size props |
@navikt/core/react/src/inline-message/icon/InlineMessageIcon.tsx |
Icon component handling variant-specific icons |
@navikt/core/react/src/inline-message/InlineMessage.stories.tsx |
Storybook stories for component documentation |
@navikt/core/react/src/index.ts |
Export addition for new component |
@navikt/core/react/package.json |
Package export configuration |
@navikt/core/css/inline-message.css |
Component styling with variant colors |
@navikt/core/css/darkside/inline-message.darkside.css |
Darkside theme styles |
@navikt/core/css/index.css |
CSS import for component styles |
@navikt/core/css/darkside/index.css |
Darkside CSS import |
@navikt/core/css/config/_mappings.js |
Style mapping configuration |
.changeset/metal-pigs-sing.md |
Changeset for the new component |
Storybook demo / Chromatic📝 Changes to review: 37f488b3f9 | 72 components | 127 stories |
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
@navikt/core/react/src/inline-message/icon/InlineMessageIcon.tsx
Outdated
Show resolved
Hide resolved
Co-authored-by: Halvor Haugan <[email protected]>
Co-authored-by: Halvor Haugan <[email protected]>
Co-authored-by: Halvor Haugan <[email protected]>
Co-authored-by: Halvor Haugan <[email protected]>
Co-authored-by: Halvor Haugan <[email protected]>
Description
https://www.figma.com/design/hbHfla3HOYzEXWhncthKPm/NEW-Alert---InfoPanel?node-id=8547-2073&m=dev
Extracted contents from #4085
Component Checklist 📝
@navikt/core/css/config/_mappings.js)@navikt/core/css/tokens.json)@navikt/aksel-stylelint/src/deprecations.ts)@navikt/core/react/src/index.tsand@navikt/core/react/package.json)@navikt/core/css/index.css)<Component>: <gitmoji?> <Text>.E.g. "Button: ✨ Add feature xyz.")