#278 Et veldig stramt tids-aspekt for token gyldighet (10 sekunder). Strammere enn faktisk gyldighetstidspunkt #186
+47
−24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…og generering av selve meldingen
terjenilssen
approved these changes
Oct 24, 2025
| class HelseIdTokenValidator( | ||
| private val issuer: String = config().helseId.issuerUrl, | ||
| private val allowedClockSkewInMs: Long = 0, | ||
| private val allowedMessageGenerationGap: Long = 10000, |
There was a problem hiding this comment.
Burde denne variabelen heller hete allowedMessageGenerationGapInMs? Og burde dette eventuelt ligge i hoplite-config slik at man kan endre der i stedet for å ha dette hardkodet i klassen? (jeg vet ikke om det er behov for å endre på terskelen, men antar at det kan være nyttig)
There was a problem hiding this comment.
Godt poeng!
Jeg skal flytte de to innstillingene inn i config fil.
…illinger inn i konfigurasjon fil
OleksandrChmyrNAV
deleted the
#278-Et-veldig-stramt-tids-aspekt-for-token-gyldighet
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
iatclaim.Oppgave: https://github.com/navikt/team-emottak-docs/issues/278