Open
Conversation
First week for Fall 2023
Finalize material for class 2
Ready for class 3
Finished Chapter 4 linear algebra
Chapter 5 notebook
Ready to test Chapter 6 in Colab
Fixed image link in Chapter6
Updated Chapter 6 image link
Final updates to Chapter 6
Added Problem Set 1
Updated Problem Set 1
Updates PS2 and PS3
Updated contributed notebooks and project description
AL Semester Project - Edited Notebook
Contributor
|
Please delete the file in the 'contrib' folder. Rename the file in the 'contrib-dev' folder to be the same name as the original file (before edits). |
adowling2
requested changes
Dec 5, 2023
Contributor
adowling2
left a comment
adowling2
left a comment
There was a problem hiding this comment.
Please make the requested changes and reupload
| "\n", | ||
| "Bingxin Yang byang3@nd.edu\n", | ||
| "\n" | ||
| "Bingxin Yang byang3@nd.edu" |
Contributor
There was a problem hiding this comment.
Should add "Edited by [your name and email] (Fall, 2023)"
| " result,error = integrate.quad(lambda E: 2*pi*(1/(pi*R*T[i]))**1.5*E**0.5*np.exp(-E/(R*T[i])),0,25)\n", | ||
| " I.append(result)\n", | ||
| " result,error = integrate.quad(lambda E: 2*pi*(1/(pi*R*T[i]))**1.5*E**0.5*np.exp(-E/(R*T[i])),low,upp)\n", | ||
| " f.append(result)\n", | ||
| "\n", | ||
| " ### END SOLUTION\n", |
Contributor
There was a problem hiding this comment.
Please check all "### END SOLUTION ###" are complete. This one is missing the trailing "###"
| "plt.tick_params(direction=\"in\",top=True, right=True) #Major tick direction: in\n", | ||
| "plt.tick_params(which=\"minor\",direction=\"in\",top=True, right=True) #minor tick direction: in\n", | ||
| "plt.xlabel('Number of Midpoint Rule Rectangles',fontsize=16, fontweight = 'bold')\n", | ||
| "plt.ylabel('Difference Between Midpoint \\nRule and Gauss Quadrature \\nIntegral Results',fontsize=16, fontweight = 'bold')\n", |
Contributor
There was a problem hiding this comment.
Change the y-axis label to be shorter, such as "f_{mid}(x) - f_{quad)(x)". You also do not need a legend on this plot because the information is redundant with the title and x-axis. For the title, try "Comparison of Midpoint and Quadrature Rules"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@adowling2