datetime: default date when intervals are in use#46
Open
alexgo91 wants to merge 1 commit intonehakadam:masterfrom
Open
datetime: default date when intervals are in use#46alexgo91 wants to merge 1 commit intonehakadam:masterfrom
alexgo91 wants to merge 1 commit intonehakadam:masterfrom
Conversation
Consider the configure intervals when defaulting to today's date.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The timepicker displays today's date&time as default when its initial value is empty.
When using intervals for hours/minutes/seconds - today's time might not comply with these intervals, which leads to unexpected behaviors.
E.g. configure AnyPicker to use
intervals: { h: 1, m: 15 }, and assume that the time now is 15:23.The previous behavior will lead to bugs since the minutes value is not 0/15/30/45.
I suggest that the timepicker will use zeros when the hours/minutes/seconds value doesn't fit the interval.