-
-
Notifications
You must be signed in to change notification settings - Fork 123
chore: use pnpm #1127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: use pnpm #1127
Conversation
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Switch the monorepo from Bun to pnpm, updating workspace configuration, scripts, CI, and documentation. Minor code cleanups are included.
- Adopt pnpm workspace (pnpm-workspace.yaml) and enforce pnpm usage
- Replace Bun invocations with pnpm across scripts, CI, and tooling; add tsx for TS script execution
- Minor logic simplifications in web app code
Reviewed Changes
Copilot reviewed 20 out of 22 changed files in this pull request and generated 4 comments.
Show a summary per file
File | Description |
---|---|
pnpm-workspace.yaml | Defines pnpm workspace packages for apps and packages folders |
packages/db/src/reset.ts | Switches execa commands from Bun to pnpm for migrations and seeding |
packages/db/package.json | Replaces Bun-based DB scripts with pnpm; uses tsx for TS entrypoints |
package.json | Removes npm workspaces, adds pnpm scripts and preinstall enforcement, adds tsx, sets pnpm as packageManager |
lefthook.yml | Replaces Bun hook commands with pnpm equivalents |
knip.config.ts | Ignores tsx for Knip due to pnpm with-env usage |
cspell.config.yml | Ignores pnpm-lock.yaml |
bunfig.toml | Removes Bun-specific config |
apps/web/src/orpc/routers/spotify.router.ts | Simplifies null/type check using optional chaining |
apps/web/src/app/[locale]/(admin)/layout.tsx | Simplifies session check using optional chaining |
apps/web/playwright.config.ts | Uses pnpm to start dev server for Playwright |
apps/web/package.json | Replaces Bun scripts with pnpm; bumps @next/bundle-analyzer |
README.md | Updates setup and usage instructions from Bun to pnpm |
AGENTS.md | Updates tooling references and commands from Bun to pnpm |
.vscode/launch.json | Updates launch commands from Bun to pnpm |
.prettierignore | Ignores pnpm-lock.yaml |
.nvmrc | Pins Node to v22.20.0 |
.npmrc | Enforces engine-strict and exact saves |
.github/workflows/ci.yml | Replaces Bun commands with pnpm in CI jobs |
.github/actions/setup/action.yml | Sets up pnpm and Node; installs dependencies with pnpm |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
No description provided.