Skip to content

Conversation

@Matyrobbrt
Copy link
Member

The previous conflict checking did not check for parameters in the same scope being renamed to the same name which could lead to ambiguous references after JST is applied and in turn behavioural differences.
Fixes #44

@Matyrobbrt Matyrobbrt added the bug Something isn't working label Apr 6, 2025
@neoforged-pr-publishing
Copy link

neoforged-pr-publishing bot commented Apr 6, 2025

  • Publish PR to GitHub Packages

Last commit published: 49b8048db936956308d8e19589ff0ee16e2d973a.

PR Publishing

The artifacts published by this PR:

Repository Declaration

In order to use the artifacts published by the PR, add the following repository to your buildscript:

repositories {
    maven {
        name 'Maven for PR #48' // https://github.com/neoforged/JavaSourceTransformer/pull/48
        url 'https://prmaven.neoforged.net/JavaSourceTransformer/pr48'
        content {
            includeModule('net.neoforged.jst', 'jst-api')
            includeModule('net.neoforged.jst', 'jst-cli')
            includeModule('net.neoforged.jst', 'jst-cli-bundle')
        }
    }
}

@Matyrobbrt Matyrobbrt requested review from Copilot and shartte and removed request for Copilot April 6, 2025 13:03
@shartte shartte merged commit a8a57ea into main Apr 7, 2025
3 checks passed
@shartte shartte deleted the gh-44 branch April 7, 2025 13:13
@neoforged-releases
Copy link

🚀 This PR has been released as JavaSourceTransformer version 1.0.70.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Application of parchment can cause behavioral changes

2 participants