Introduce a way to only validate a subset of the ATs #49
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
shartte
reviewed
Apr 25, 2025
| public AccessTransformerValidation validation = AccessTransformerValidation.LOG; | ||
|
|
||
| // TODO: as is, either this or the normal option is required | ||
| @CommandLine.Option(names = "--access-transformer-no-validation") |
Contributor
There was a problem hiding this comment.
--access-transformer-validation-exclude ??
neoforged-automation
bot
added
the
needs rebase
Contributor
|
@Technici4n, this pull request has conflicts, please resolve them for this PR to move forward. |
Contributor
|
This is now fixed via #50 and filtering the problem report by path in NFRT |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Easy enough actually. What I am not sure about is what the CLI args should look like for this feature.
This will be useful for neoforged/ModDevGradle#236.